Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Update cell test template to include id #11749

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 5, 2024

Fix regression introduced in #11737

<Success> and <Failure> components had extra types added that require the id to be passed to the components. The tests that we generate did not do this, so we got a type error like this

image

This PR updates the cell test template to include the id when needed

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 5, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Dec 5, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Dec 5, 2024
@Tobbe Tobbe force-pushed the tobbe-fix-cell-test-template branch from 6d01f34 to 4fc464a Compare December 5, 2024 15:37
@Tobbe Tobbe merged commit 495f625 into redwoodjs:main Dec 5, 2024
50 checks passed
@Tobbe Tobbe deleted the tobbe-fix-cell-test-template branch December 5, 2024 16:30
@Tobbe Tobbe modified the milestones: next-release-patch, v8.4.3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant