Bump node target

[jtoar]

Both Netlify and Vercel's default Node.js version is v14.x.x.¹² Currently, v14.19.0 is the latest v14.x release.

To bump the Node.js version we target, this PR changes two parameters: TARGETS_NODE, which is passed to Babel's preset-env, and ESBuild's target parameter for its build API.

TARGETS_NODE mainly affects how the packages in the Redwood framework are built, which indirectly affects the Redwood projects that use them. I.e., TARGETS_NODE doesn't really affect how redwood projects are built (when users run yarn rw build). Instead, the target param for ESBuild matters.

But TARGETS_NODE does directly affect CLI Commands that use registerApiSideBabelHook:

• yarn rw console
• yarn rw exec
• yarn rw data-migrate up

Footnotes

1. https://docs.netlify.com/functions/build-with-javascript/#runtime-settings ↩

2. https://vercel.com/docs/runtimes#official-runtimes/node-js/node-js-version ↩

[thedavidprice]

Suggested change

	const TARGETS_NODE = '14.18.3'
	const TARGETS_NODE = '14.18'

Is it valid to omit the semver patch?

[jtoar]

We used to omit it so I imagine it is, but there should be an official answer somewhere; I'll try to find it.

[jtoar]

I couldn't find any docs but it looks like this is what babel does with the value: https://github.com/babel/babel/blob/e45d86c33380e2e7e98b5713443b8e20658494a9/packages/babel-helper-compilation-targets/src/utils.ts#L19-L37.

Basically, passing what we currently have ('12.16') ends up being '12.16.0'. We should probably either 1) pin the version explicitly or 2) use legit semver, like '^14.18.3'.

Netlify and Vercel both say that their default is 14.x.

[jtoar]

Well it looks like babel doesn't like '^14.18.3': https://github.com/redwoodjs/redwood/runs/4932747479?check_suite_focus=true#step:9:21

[jtoar]

@thedavidprice whatever we pass goes through semver.valid which only seems to like something like '14.18.3'—a semver without any of the range specifiers. If we leave off the patch it's filled in for us with a 0.

I'd need to dig through babel more to understand the full implications, but one thing to keep in mind is that this isn't the the runtime version. It seems like that number is up to netlify, vercel, and to some degree, the user.

[thedavidprice]

@jtoar Great to see this one started. We should update here as well (correct?): https://github.com/redwoodjs/redwood/blob/94c13c78dd8a6eb77337708cbceba49fbf82fb71/packages/internal/src/build/babel/api.ts

My questions about this change are (no surprises):

1. is this backward compatible?
2. how and what do we need to communicate about this change in the release notes?

What if we added custom babel.config.js to my deploy test project and confirmed working?

[jtoar]

We should update here as well (correct?)

Ah yeah great catch!

is this backward compatible?

I want to say that since we've got redwood projects configured to use most of the JS latest and greatest via babel, this isn't breaking, but I need to confirm.

how and what do we need to communicate about this change in the release notes?

We need to communicate that we did it, and also that most users should experience no difference. If someone was trying to use a specific node.js feature (not javascript, but node.js explicitly), they have access to it now. And I can look at the breaking changes from 12 to 14.

What if we added custom babel.config.js to my deploy test project and confirmed working?

That'd be a great way to test!

[thedavidprice]

@jtoar in parallel to this, do we need to take a look at our Browserslist settings?

[thedavidprice]

@jtoar let me know if there's anything I can test here (e.g. deployments) before next CT meeting

[jtoar]

in parallel to this, do we need to take a look at our Browserslist settings?

I need to read-up on how browserlist queries work, but when I glanced at them, they looked a lot more up to date than our node target.

[jtoar]

• try deploying
• review how building the framework changes
• review how building redwood apps change
• investigate if/how this affects other babel packages (e.g. runtime)

[netlify]

✅ Deploy Preview for redwoodjs-docs canceled.

Name	Link
🔨 Latest commit	8b7841e
🔍 Latest deploy log	https://app.netlify.com/sites/redwoodjs-docs/deploys/62cee3d319e48b0009e6a8bf

[jtoar]

I'm going to combine this with #5405. The work will be done there.