Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency esbuild to v0.14.17 #4333

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 2, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
esbuild 0.14.16 -> 0.14.17 age adoption passing confidence

Release Notes

evanw/esbuild

v0.14.17

Compare Source

  • Attempt to fix an install script issue on Ubuntu Linux (#​1711)

    There have been some reports of esbuild failing to install on Ubuntu Linux for a while now. I haven't been able to reproduce this myself due to lack of reproduction instructions until today, when I learned that the issue only happens when you install node from the Snap Store instead of downloading the official version of node.

    The problem appears to be that when node is installed from the Snap Store, install scripts are run with stderr not being writable? This then appears to cause a problem for esbuild's install script when it uses execFileSync to validate that the esbuild binary is working correctly. This throws the error EACCES: permission denied, write even though this particular command never writes to stderr.

    Node's documentation says that stderr for execFileSync defaults to that of the parent process. Forcing it to 'pipe' instead appears to fix the issue, although I still don't fully understand what's happening or why. I'm publishing this small change regardless to see if it fixes this install script edge case.

  • Avoid a syntax error due to --mangle-props=. and super() (#​1976)

    This release fixes an issue where passing --mangle-props=. (i.e. telling esbuild to mangle every single property) caused a syntax error with code like this:

    class Foo {}
    class Bar extends Foo {
      constructor() {
        super();
      }
    }

    The problem was that constructor was being renamed to another method, which then made it no longer a constructor, which meant that super() was now a syntax error. I have added a workaround that avoids renaming any property named constructor so that esbuild doesn't generate a syntax error here.

    Despite this fix, I highly recommend not using --mangle-props=. because your code will almost certainly be broken. You will have to manually add every single property that you don't want mangled to --reserve-props= which is an excessive maintenance burden (e.g. reserve parse to use JSON.parse). Instead I recommend using a common pattern for all properties you intend to be mangled that is unlikely to appear in the APIs you use such as "ends in an underscore." This is an opt-in approach instead of an opt-out approach. It also makes it obvious when reading the code which properties will be mangled and which ones won't be.


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the release:chore This PR is a chore (means nothing for users) label Feb 2, 2022
@renovate renovate bot force-pushed the renovate/esbuild-0.x branch from f92e217 to 4597409 Compare February 2, 2022 10:45
@renovate renovate bot merged commit 98cd903 into main Feb 2, 2022
@renovate renovate bot deleted the renovate/esbuild-0.x branch February 2, 2022 12:06
@jtoar jtoar added this to the next-release milestone Feb 2, 2022
dac09 added a commit to dac09/redwood that referenced this pull request Feb 2, 2022
…d into fix/standardize-jest-config

* 'fix/standardize-jest-config' of github.com:dac09/redwood:
  Update dependency @types/netlify-identity-widget to v1.9.3 (redwoodjs#4343)
  Update dependency webpack-dev-server to v4.7.4 (redwoodjs#4337)
  Update dependency @clerk/clerk-sdk-node to v2.8.0 (redwoodjs#4336)
  Update dependency esbuild to v0.14.17 (redwoodjs#4333)
@thedavidprice thedavidprice modified the milestones: next-release, v0.44.0 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants