Update dependency esbuild to v0.14.17 #4333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.14.16
->0.14.17
Release Notes
evanw/esbuild
v0.14.17
Compare Source
Attempt to fix an install script issue on Ubuntu Linux (#1711)
There have been some reports of esbuild failing to install on Ubuntu Linux for a while now. I haven't been able to reproduce this myself due to lack of reproduction instructions until today, when I learned that the issue only happens when you install node from the Snap Store instead of downloading the official version of node.
The problem appears to be that when node is installed from the Snap Store, install scripts are run with stderr not being writable? This then appears to cause a problem for esbuild's install script when it uses
execFileSync
to validate that the esbuild binary is working correctly. This throws the errorEACCES: permission denied, write
even though this particular command never writes to stderr.Node's documentation says that stderr for
execFileSync
defaults to that of the parent process. Forcing it to'pipe'
instead appears to fix the issue, although I still don't fully understand what's happening or why. I'm publishing this small change regardless to see if it fixes this install script edge case.Avoid a syntax error due to
--mangle-props=.
andsuper()
(#1976)This release fixes an issue where passing
--mangle-props=.
(i.e. telling esbuild to mangle every single property) caused a syntax error with code like this:The problem was that
constructor
was being renamed to another method, which then made it no longer a constructor, which meant thatsuper()
was now a syntax error. I have added a workaround that avoids renaming any property namedconstructor
so that esbuild doesn't generate a syntax error here.Despite this fix, I highly recommend not using
--mangle-props=.
because your code will almost certainly be broken. You will have to manually add every single property that you don't want mangled to--reserve-props=
which is an excessive maintenance burden (e.g. reserveparse
to useJSON.parse
). Instead I recommend using a common pattern for all properties you intend to be mangled that is unlikely to appear in the APIs you use such as "ends in an underscore." This is an opt-in approach instead of an opt-out approach. It also makes it obvious when reading the code which properties will be mangled and which ones won't be.Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.