Update generated render.yaml #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running into an error that said `--production=false` is not a flag. After changing `TRUE` -> `true` it went away. Not sure what the best way to test this change though.
|
That's interesting. |
|
Looks like it should be lowercase |
I'm afraid we don't have a good way to test this 🙁 Manual testing is the way to go for now I think |
Tobbe
added
release:fix
|
Hey sorry everyone, I tested the change in the last PR by copy past in my config and I probably didn't do it correctly. |
jtoar
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
@simoncrypta yeah I just pinged David about the config in the deploy target CI repo, will see what he says. In the meantime, I tested this manually and it works.
|
Also, render docs here: https://render.com/docs/environment-variables#node-1 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
I was running into an error that said `--production=false` is not a flag. After changing `TRUE` -> `true` it went away. Not sure what the best way to test this change though. Co-authored-by: Simon Gagnon <git@simoncrypta.dev> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar
added a commit
that referenced
this pull request
Nov 4, 2022
I was running into an error that said `--production=false` is not a flag. After changing `TRUE` -> `true` it went away. Not sure what the best way to test this change though. Co-authored-by: Simon Gagnon <git@simoncrypta.dev> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
dac09
added a commit
that referenced
this pull request
Nov 7, 2022
…aching * 'main' of github.com:redwoodjs/redwood: (21 commits) [Tutorial]: Fix Typescript code blocks inconsistency (#6801) chore: update all contributors Custom auth: Fix comment in template (#6804) fix(deps): update dependency eslint to v8.26.0 (#6785) [CRWA]: Switch to using enquirer, add engine compatibility override option (#6723) (docs): Minor Command update about Storybook (#6722) docs: Add mocking useLocation to docs (#6791) Update generated render.yaml (#6771) fix flightcontrol config template (#6789) fix: publish canary using premajor (#6794) Strip resetToken and resetTokenExpiresAt from dbAuth forgotPassword handler (#6778) Fix WebAuthn when event body is base64 encoded (like when deploying to Vercel) (#6757) fix(deps): update jest monorepo (#6787) fix(deps): update dependency react-hook-form to v7.39.1 (#6786) fix(deps): update dependency fastify to v4.9.2 (#6781) fix(deps): update dependency @apollo/client to v3.7.1 (#6780) chore: fix and rebuild test project fixture (#6775) fix: add prisma resolutions to tutorial e2e test proj (#6772) fix(deps): update prisma monorepo to v4.5.0 (#6485) Fix dbauth webauthn template (redundant type import) (#6769) ...
jtoar
added a commit
that referenced
this pull request
Nov 8, 2022
I was running into an error that said `--production=false` is not a flag. After changing `TRUE` -> `true` it went away. Not sure what the best way to test this change though. Co-authored-by: Simon Gagnon <git@simoncrypta.dev> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
jtoar
added a commit
that referenced
this pull request
Nov 8, 2022
I was running into an error that said `--production=false` is not a flag. After changing `TRUE` -> `true` it went away. Not sure what the best way to test this change though. Co-authored-by: Simon Gagnon <git@simoncrypta.dev> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an error that said
--production=falseis not a flag. After changingTRUE->trueit went away. Not sure what the best way to test this change though.