[CRWA]: Switch to using enquirer, add engine compatibility override option #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![redwoodjs-bot[bot]](https://avatars.githubusercontent.com/in/121504?s=60&v=4){kind=small}
…ption (#6723) * Add engine check and prompt * Language tweak * Add link and additional text to error * Migrate to Listr2 * WIP * Complete engine checks * Typo, concurrent, simpler output * Fix broken quit process, add quit install message * Remove ToDo, update code comments * Make suggested visual changes * Collapse Listr
redwoodjs-bot
bot
added
cherry-pick
release:feature
jtoar
deleted the
cherry-pick-next-d75569e86c018ce458d3c850da0f03297b498572
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey All,
This should be considered a draft, I want to do some more testing. But I drafted what CRWA could look like with a switch over to enquirer. I think this sets a basis for future improvements really nicely.
One area I ran into issues was with the engine checks. I was hoping to only have one Listr, however had to keep it split out into it's own seperate Listr process because of the bug with overflowing terminal height and text display (see listr2/listr2#296).
Once @jtoar moves other areas of the codebase over to enquirer I can use this as a basis for the main PR (#6380) . But maybe we don't need to wait?