-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: have scaffold set titleTo and buttonTo depend on getTemplateStrings #6806
Merged
cannikin
merged 3 commits into
redwoodjs:main
from
daniel-escoto:dbe-fix-scaffold-layout-generator
Nov 7, 2022
Merged
fix: have scaffold set titleTo and buttonTo depend on getTemplateStrings #6806
cannikin
merged 3 commits into
redwoodjs:main
from
daniel-escoto:dbe-fix-scaffold-layout-generator
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for the PR @daniel-escoto @cannikin your domain I believe :) |
cannikin
approved these changes
Nov 7, 2022
Whoops! Forgot that you can create stuff in a sub directory! Thanks for this fix @daniel-escoto! I double checked and the test project fixture doesn't need to be updated. |
jtoar
pushed a commit
that referenced
this pull request
Nov 7, 2022
jtoar
pushed a commit
that referenced
this pull request
Nov 8, 2022
jtoar
pushed a commit
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a fix for this issue: #6654
Gitpod snapshot: https://gitpod.io#snapshot/e0161d70-2435-435a-a229-0578ef51a48b
Steps to reproduce:
yarn rw g scaffold admin/UserExample
admin/user-examples
Solution description:
Generate
titleTo
andbuttonTo
in the same way that scaffold route names are generated, with the functiongetTemplateStrings()