Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: have scaffold set titleTo and buttonTo depend on getTemplateStrings #6806

Merged

Conversation

daniel-escoto
Copy link
Contributor

Implement a fix for this issue: #6654

Gitpod snapshot: https://gitpod.io#snapshot/e0161d70-2435-435a-a229-0578ef51a48b

Steps to reproduce:

  1. Open starter repo in Gitpod
  2. yarn rw g scaffold admin/UserExample
  3. Navigate to admin/user-examples
  4. See the following error:
    Screen Shot 2022-11-05 at 9 52 18 PM

Solution description:
Generate titleTo and buttonTo in the same way that scaffold route names are generated, with the function getTemplateStrings()

@dac09
Copy link
Contributor

dac09 commented Nov 7, 2022

Thank you for the PR @daniel-escoto

@cannikin your domain I believe :)

@dac09 dac09 added the release:fix This PR is a fix label Nov 7, 2022
@dac09 dac09 added this to the next-release-patch milestone Nov 7, 2022
@cannikin cannikin added the fixture-ok Override the test project fixture check label Nov 7, 2022
@cannikin
Copy link
Member

cannikin commented Nov 7, 2022

Whoops! Forgot that you can create stuff in a sub directory! Thanks for this fix @daniel-escoto!

I double checked and the test project fixture doesn't need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants