Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: Only redirect in getToken on InteractionRequiredAuthError #7386

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Azure: Only redirect in getToken on InteractionRequiredAuthError #7386

merged 1 commit into from
Jan 20, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jan 20, 2023 •
edited
Loading

Following the guidelines and code samples in https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-browser/docs/acquire-token.md we're now only redirecting in getToken if we get an InteractionRequiredAuthError

Fixes #7112

@Tobbe Tobbe added the release:fix This PR is a fix label Jan 20, 2023
@Tobbe Tobbe self-assigned this Jan 20, 2023
@Tobbe Tobbe enabled auto-merge (squash) January 20, 2023 07:38
@Tobbe Tobbe merged commit c4c9853 into redwoodjs:main Jan 20, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jan 20, 2023
@Tobbe Tobbe deleted the tobbe-azure-interaction-required-auth-error branch January 20, 2023 08:26
@Tobbe Tobbe mentioned this pull request Jan 20, 2023
Closed
1 task
@jtoar jtoar modified the milestones: next-release, v4.0.0 Jan 26, 2023
jtoar pushed a commit that referenced this pull request Jan 30, 2023
@Tobbe @jtoar
Azure: Only redirect in getToken on InteractionRequiredAuthError (#7386)
a9e3c62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tobbe Tobbe

Labels
release:fix This PR is a fix
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

[Bug?]: Azure Active Directory Authentication – Redirect to authorization endpoint despite @skipAuth
2 participants
@Tobbe @jtoar