Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(ts): Add temporary work around for defineScenario typedef #7527

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Feb 1, 2023

No description provided.

@jtoar jtoar added the release:fix This PR is a fix label Feb 1, 2023
Copy link
Collaborator

@simoncrypta simoncrypta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do my day Danny 😁

@dac09 dac09 enabled auto-merge (squash) February 1, 2023 05:19
@dac09 dac09 merged commit 892dfca into redwoodjs:main Feb 1, 2023
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 1, 2023
@Tobbe
Copy link
Member

Tobbe commented Feb 1, 2023

@dac09 (or maybe @simoncrypta). Can I have some more context here please? Is there an issue to link this to?
If we ever want to bring back more typesafety here it'd be good to know what this PR fixed, so we don't re-introduce that issue again 🙂

@jtoar
Copy link
Contributor

jtoar commented Feb 1, 2023

@Tobbe see @simoncrypta's comment here #6915 (comment). We had an impromptu meeting a few hours ago when Simon reached out to me about an undocumented and potentially breaking change in v4 introduced in #6915; the TL;DR of it is that this part of #6915 was breaking for Simon, and @dac09 thinks he could implement it in a way that's not breaking. This was just the hotfix to get out in the meantime so Simon could upgrade

@Tobbe
Copy link
Member

Tobbe commented Feb 1, 2023

Thanks @jtoar that's perfect 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants