-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix(ts): Add temporary work around for defineScenario typedef #7527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do my day Danny 😁
16 replays were recorded for 995f006. 16 Passed
requireAuth graphql checks
|
@dac09 (or maybe @simoncrypta). Can I have some more context here please? Is there an issue to link this to? |
@Tobbe see @simoncrypta's comment here #6915 (comment). We had an impromptu meeting a few hours ago when Simon reached out to me about an undocumented and potentially breaking change in v4 introduced in #6915; the TL;DR of it is that this part of #6915 was breaking for Simon, and @dac09 thinks he could implement it in a way that's not breaking. This was just the hotfix to get out in the meantime so Simon could upgrade |
Thanks @jtoar that's perfect 🙂 |
No description provided.