Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(webAuthn) use globalThis, not process.env #7639

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Feb 14, 2023

Closes #7637.

There's probably some tests that need updating here.

@jtoar jtoar requested a review from Tobbe February 14, 2023 19:40
@jtoar jtoar changed the title fix: use globalThis, not process.env fix:(webAuthn) use globalThis, not process.env Feb 14, 2023
@jtoar jtoar added release:fix This PR is a fix fixture-ok Override the test project fixture check labels Feb 14, 2023
Copy link
Member

@Tobbe Tobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this working with both webpack and vite

@jtoar jtoar merged commit 89f851d into main Feb 14, 2023
@jtoar jtoar deleted the ds-fix-webAuthn-getApiUrl branch February 14, 2023 23:23
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Feb 14, 2023
jtoar added a commit that referenced this pull request Feb 14, 2023
* fix: use globalThis, not process.env

* copy how dbAuth does it
jtoar added a commit that referenced this pull request Feb 14, 2023
* fix: use globalThis, not process.env

* copy how dbAuth does it
@jtoar jtoar modified the milestones: next-release-patch, v4.1.4 Feb 14, 2023
jtoar added a commit that referenced this pull request Feb 14, 2023
* fix: use globalThis, not process.env

* copy how dbAuth does it
dac09 added a commit to dac09/redwood that referenced this pull request Feb 21, 2023
* 'main' of github.com:redwoodjs/redwood: (33 commits)
  chore(deps): update dependency lerna to v6.5.1 (redwoodjs#7631)
  Get rid of red squiggles in new lambda functions (redwoodjs#7640)
  chore: add redirects for compressed v2, v3 docs
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.3 (redwoodjs#7645)
  chore(deps): update dependency @types/react-dom to v18.0.11 (redwoodjs#7644)
  7482/validators exclude include caseinsensitive (redwoodjs#7573)
  chore(deps): update dependency @clerk/clerk-react to v4.11.3 (redwoodjs#7642)
  chore(deps): update dependency @replayio/playwright to v0.3.21 (redwoodjs#7643)
  chore(deps): update dependency supertokens-auth-react to v0.31.1 (redwoodjs#7628)
  chore(deps): update dependency @types/vscode to v1.75.1 (redwoodjs#7630)
  fix:(webAuthn) use `globalThis`, not `process.env` (redwoodjs#7639)
  feat(api): support building .jsx, .tsx files (redwoodjs#7638)
  chore(CI): CI telemetry checking (redwoodjs#7623)
  chore(deps): update dependency supertokens-node to v13.0.2 (redwoodjs#7629)
  fix(docs): typo in `GraphQL` docs (redwoodjs#7634)
  fix(ts): Undo skipLibCheck change (redwoodjs#7633)
  fix(generator): add dotAll to Router regex (redwoodjs#7605)
  chore(deps): update dependency @clerk/types to v3.27.0 (redwoodjs#7614)
  fix(deps): update dependency eslint to v8.34.0 (redwoodjs#7615)
  fix(deps): update dependency systeminformation to v5.17.9 (redwoodjs#7622)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Webauthn not working after 4.0.0
2 participants