chore(vite): Rename entry-client.tsx to entry.client #8592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added
release:breaking
|
@cannikin would you mind giving this a once over? Small change! |
…into chore/rename-entry-client * 'chore/rename-entry-client' of github.com:dac09/redwood: Move fastify.logger.infos to fastify.logger.traces (redwoodjs#8590) Make the fastify logger respect the LOG_LEVEL value set in the env (redwoodjs#8588) feat: Update the SDL types lib (redwoodjs#8586) Fix the codegen path for the GraphQL context objcet (redwoodjs#8585) chore(deps): update dependency @clerk/types to v3.42.0 (redwoodjs#8584) feat(codemod): Add codemod for js to jsx conversion (redwoodjs#8551)
cannikin
approved these changes
Jun 13, 2023
jtoar
reviewed
Jun 14, 2023
| const viteConfigPath = `${getPaths().web.base}/vite.config.${ | ||
| ts ? 'ts' : 'js' | ||
| }` | ||
| const viteConfigPath = getPaths().web.viteConfig |
There was a problem hiding this comment.
@dac09 this is coming up as null for me. Took a quick look and I think it's because resolveFile tries to find a file that exists, but in projects that aren't configured for Vite (the ones that would be more likely to use this command), there's no file, .js or .ts to resolve:
redwood/packages/project-config/src/paths.ts
Line 194 in cd34b8b
redwood/packages/project-config/src/paths.ts
Lines 126 to 137 in cd34b8b
There was a problem hiding this comment.
Ah right, ofcourse. That's probably why I did it this way before ;) I'll revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the Vite entry point from
entry-clienttoentry.clientas per discussion during CTM.This is sort-of a breaking change - if user's already opted in to Vite. We need to find a good place to mention this in the release notes.