chore: RedwoodJS GraphQL subscription templates now use Dynamic Topic IDs #8766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
changed the title
Josh-Walker-GM
approved these changes
Jun 29, 2023
dthyresson
added
release:feature
jtoar
pushed a commit
that referenced
this pull request
Jun 30, 2023
… IDs (#8766) * Update pub sub types to send dynamic id * Updates realtime channel type * Fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the templates used when setting up Redwood Realtime and the generator for subscriptions to use what https://the-guild.dev/graphql/yoga-server/docs/features/subscriptions#topic-with-dynamic-id calls "Dynamic topic ids".
In short, instead of the message incorporating the topic name and the id like "newMessage:1", one can subscript and public the the topic with an id.
This significantly simplifies the types used of the pubSub channels.