docs: update ArticleQuery type in routing-params.md #8895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Jul 13, 2023
jtoar
pushed a commit
that referenced
this pull request
Jul 17, 2023
Closes #8889 This PR replaces `ArticleQuery` type with `FindArticleQuery`, which is the generated code when running `yarn rw g cell Article` (any singular-form name). To be fair, it does not matter whether `ArticleQuery` or `FindArticleQuery` is used (ie. will not cause error either way), _except_ when user copy-pastes from the following block and does not modify their auto-generated code accordingly.  Thus it may be better to update the tutorial code to reflect the auto-generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8889
This PR replaces
ArticleQuerytype withFindArticleQuery, which is the generated code when runningyarn rw g cell Article(any singular-form name).To be fair, it does not matter whether
ArticleQueryorFindArticleQueryis used (ie. will not cause error either way), except when user copy-pastes from the following block and does not modify their auto-generated code accordingly.Thus it may be better to update the tutorial code to reflect the auto-generated code.