-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support alias paths on vite #9242
Conversation
Signed-off-by: Esteban Rojas <14810250+esteban-url@users.noreply.github.com>
@dac09 I was thinking that it's maybe a good idea to keep the old implementation for legacy (webpack) projects. I've added support for both bundlers now. please let me know if there's anything else i might be overlooking. |
true | ||
) | ||
expect(ensurePosixPath(webPaths['@ui'])).toMatchInlineSnapshot( | ||
`"./src/ui"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @esteban-url just to check - why is the ./
required for vite? src/ui should still be working I believe?
Looking good esteban, but couple of things worth discussing:
Both discussion points, not suggesting we do either just yet |
Hey @esteban-url picking this up again. So I've taken another look at this, and I think maybe the module aliases are broken with prerender (even without the change in this PR). Any chance you'll have time to take a look again? Totally understand if you're busy! Let me know either way ✌️ |
Closing this as superceded by #9574 Thank you again esteban! |
Since we've moved to vite as the bundler for the web side, we need to adjust the way we handle the values.
not sure this is the best way to do it, but it does provide support for alias paths and fixes #8666