chore: increase batch size of db migration [ci skip]

reearth · Feb 22, 2022 · fbbca4d · fbbca4d
1 parent f66f9a3
commit fbbca4d
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 5 deletions.
diff --git a/internal/infrastructure/mongo/migration/201217132559_add_scene_widget_id.go b/internal/infrastructure/mongo/migration/201217132559_add_scene_widget_id.go
@@ -13,7 +13,7 @@ func AddSceneWidgetId(ctx context.Context, c DBClient) error {
 	col := c.WithCollection("scene")
 
 	return col.Find(ctx, bson.D{}, &mongodoc.BatchConsumer{
-		Size: 50,
+		Size: 1000,
 		Callback: func(rows []bson.Raw) error {
 
 			ids := make([]string, 0, len(rows))

diff --git a/internal/infrastructure/mongo/migration/201217193948_add_scene_default_tile.go b/internal/infrastructure/mongo/migration/201217193948_add_scene_default_tile.go
@@ -47,7 +47,7 @@ func AddSceneDefaultTile(ctx context.Context, c DBClient) error {
 	log.Infof("migration: AddSceneDefaultTile: filter: %+v\n", filter)
 
 	return col.Find(ctx, filter, &mongodoc.PropertyBatchConsumer{
-		Size: 50,
+		Size: 1000,
 		Callback: func(properties []*property.Property) error {
 			log.Infof("migration: AddSceneDefaultTile: hit properties: %d\n", len(properties))
 

diff --git a/internal/infrastructure/mongo/migration/210310145844_remove_preview_token.go b/internal/infrastructure/mongo/migration/210310145844_remove_preview_token.go
@@ -12,7 +12,7 @@ func RemovePreviewToken(ctx context.Context, c DBClient) error {
 	col := c.WithCollection("project")
 
 	return col.Find(ctx, bson.D{}, &mongodoc.BatchConsumer{
-		Size: 50,
+		Size: 1000,
 		Callback: func(rows []bson.Raw) error {
 
 			ids := make([]string, 0, len(rows))

diff --git a/internal/infrastructure/mongo/migration/210730175108_add_scene_align_system.go b/internal/infrastructure/mongo/migration/210730175108_add_scene_align_system.go
@@ -16,7 +16,7 @@ func AddSceneAlignSystem(ctx context.Context, c DBClient) error {
 	col := c.WithCollection("scene")
 
 	return col.Find(ctx, bson.D{}, &mongodoc.BatchConsumer{
-		Size: 50,
+		Size: 1000,
 		Callback: func(rows []bson.Raw) error {
 			ids := make([]string, 0, len(rows))
 			newRows := make([]interface{}, 0, len(rows))

diff --git a/internal/infrastructure/mongo/migration/220214180713_split_schema_of_properties.go b/internal/infrastructure/mongo/migration/220214180713_split_schema_of_properties.go
@@ -15,7 +15,7 @@ func SplitSchemaOfProperties(ctx context.Context, c DBClient) error {
 	return col.Find(ctx, bson.M{
 		"schema": bson.M{"$exists": true},
 	}, &mongodoc.BatchConsumer{
-		Size: 50,
+		Size: 1000,
 		Callback: func(rows []bson.Raw) error {
 			ids := make([]string, 0, len(rows))
 			newRows := make([]interface{}, 0, len(rows))

diff --git a/internal/infrastructure/mongo/migration/migrations.go b/internal/infrastructure/mongo/migration/migrations.go
diff --git a/tools/cmd/migrategen/main.go b/tools/cmd/migrategen/main.go
@@ -101,6 +101,10 @@ import "context"
 func {{.Name}}(ctx context.Context, c DBClient) error {
 	// TODO: Write your migration code here
 
+	// WARNING:
+	// If the migration takes too long, the deployment may fail in a serverless environment.
+	// Set the batch size to as large a value as possible without using up the RAM of the deployment destination.
+
 	return nil
 }
 `))
@@ -109,6 +113,9 @@ var templ2 = template.Must(template.New("generated2").Parse(`// Code generated b
 
 package migration
 
+// WARNING:
+// If the migration takes too long, the deployment may fail in a serverless environment.
+// Set the batch size to as large a value as possible without using up the RAM of the deployment destination.
 var migrations = map[int64]MigrationFunc{
 {{range .}}  {{.Key}}: {{.Name}},
 {{end}}}