Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: auth to work with zero config #131

Merged
merged 6 commits into from
Apr 4, 2022
Merged

fix: auth to work with zero config #131

merged 6 commits into from
Apr 4, 2022

Conversation

yk-eukarya
Copy link
Contributor

Overview

  • fix config bugs
  • add .env.example file

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

add .env.example file
@yk-eukarya yk-eukarya self-assigned this Mar 30, 2022
@yk-eukarya yk-eukarya requested a review from rot1024 as a code owner March 30, 2022 23:58
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if you write localhost as a reference in .env.example, it will be misunderstood that it needs to be configured to start Re:Earth, so it would be easier to understand if you write a dummy URL such as https://reearth.example.com.

.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #131 (a07a3b9) into main (47be6ab) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   36.25%   36.24%   -0.01%     
==========================================
  Files         326      326              
  Lines       29069    29081      +12     
==========================================
+ Hits        10538    10540       +2     
- Misses      17576    17585       +9     
- Partials      955      956       +1     
Impacted Files Coverage Δ
internal/app/auth_server.go 0.00% <0.00%> (ø)
internal/app/jwt.go 0.00% <0.00%> (ø)
internal/app/web.go 0.00% <0.00%> (ø)
internal/app/config.go 35.10% <85.71%> (+0.66%) ⬆️

@rot1024 rot1024 merged commit 3cbb456 into main Apr 4, 2022
@rot1024 rot1024 deleted the fix/zero_config branch April 4, 2022 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants