Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: add an opacity slider to map tiles #138

Merged
merged 3 commits into from
May 10, 2022
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Apr 28, 2022

Overview

closes reearth/reearth-visualizer#278
Users want to be able to set an opacity to map tiles. So, this adds opacity to tiles :P

What I've done

Added slider as an option to schema ui in plugin_manifest
Added Opacity field to tile in manifest w min 0 and max 1, default 1.
Updated appropriate domain models, converters, etc

How I tested

Checked if I could view field in UI, has default and can be changed.

@KaWaite KaWaite requested review from HideBa and rot1024 as code owners April 28, 2022 04:24
@KaWaite KaWaite changed the title add slider ui type, add opacity to tile feat: add an opacity slider to map tiles Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #138 (df9390b) into main (2c02203) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   36.68%   36.68%   -0.01%     
==========================================
  Files         331      331              
  Lines       29888    29890       +2     
==========================================
  Hits        10964    10964              
- Misses      17923    17925       +2     
  Partials     1001     1001              
Impacted Files Coverage Δ
internal/adapter/gql/gqlmodel/convert_property.go 1.30% <0.00%> (-0.01%) ⬇️
pkg/property/schema_field_ui.go 85.71% <ø> (ø)

@KaWaite KaWaite merged commit 4f72b87 into main May 10, 2022
@KaWaite KaWaite deleted the feat/add-tile-opacity branch May 10, 2022 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE]: Add opacity field to tile map
2 participants