Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: add timeline settings to scene property #153

Merged
merged 5 commits into from
May 31, 2022
Merged

feat: add timeline settings to scene property #153

merged 5 commits into from
May 31, 2022

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented May 27, 2022

Note:

  • Already manually tested
  • The implementation of the prefix and suffix translation feature is not yet complete. This will be done in another PR if there is room. For now, we only allow them to be specified in the manifest file.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #153 (3e1b581) into main (c6e98c0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   34.74%   34.76%   +0.02%     
==========================================
  Files         350      350              
  Lines       31847    31857      +10     
==========================================
+ Hits        11065    11075      +10     
  Misses      19773    19773              
  Partials     1009     1009              
Impacted Files Coverage Δ
pkg/property/schema_field_ui.go 85.71% <ø> (ø)
pkg/plugin/manifest/schema_translation.go 81.76% <100.00%> (+1.22%) ⬆️

@rot1024 rot1024 marked this pull request as ready for review May 27, 2022 10:37
@rot1024 rot1024 requested a review from HideBa as a code owner May 27, 2022 10:37
@rot1024 rot1024 merged commit 602ec07 into main May 31, 2022
@rot1024 rot1024 deleted the timeline branch May 31, 2022 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant