This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/authentication-system #63 +/- ##
=============================================================
Coverage ? 16.50%
=============================================================
Files ? 249
Lines ? 43270
Branches ? 0
=============================================================
Hits ? 7141
Misses ? 35114
Partials ? 1015 |
mimoham24
changed the title
feat: create mailer (go-mailer is used)
feat: create mailer
Oct 27, 2021
rot1024
suggested changes
Oct 28, 2021
break down MailerConfig struct
rot1024
suggested changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are mailers tested? See also: https://github.com/stanislas-m/mocksmtp
Still draft? |
rot1024
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codes seem ok, and do test whether smtp works well with https://github.com/mailhog/MailHog
…th/reearth-backend into auth/mailer # Conflicts: # go.mod # internal/app/config.go
…th/reearth-backend into auth/mailer # Conflicts: # go.mod # internal/app/config.go
…th/reearth-backend into auth/mailer # Conflicts: # go.mod
…th/reearth-backend into auth/mailer # Conflicts: # go.mod
rot1024
approved these changes
Nov 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Unit testing:
MailHog:
Which point I want you to review particularly
Memo