This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
refactor: signup #65
Merged
refactor: signup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/authentication-system #65 +/- ##
=============================================================
Coverage ? 16.61%
=============================================================
Files ? 254
Lines ? 43850
Branches ? 0
=============================================================
Hits ? 7287
Misses ? 35528
Partials ? 1035 |
mimoham24
requested review from
rot1024,
HideBa and
yk-eukarya
and removed request for
rot1024
rot1024
suggested changes
Oct 25, 2021
rot1024
suggested changes
Nov 4, 2021
rot1024
suggested changes
Nov 10, 2021
rot1024
suggested changes
Nov 15, 2021
rot1024
reviewed
Nov 15, 2021
…th/reearth-backend into auth/signup # Conflicts: # go.mod # go.sum # internal/usecase/interfaces/user.go # pkg/user/user_test.go
rot1024
suggested changes
Nov 24, 2021
rot1024
suggested changes
Nov 24, 2021
* - password reset * - refactor * - implement the memory repo * - remove unnecessary structs * - fix password reset token validation - add unit test * - fix linting * - fix unit test * - refactor * - replace uuid lib - rename validate method * - fix go mod * - fix go mod * - enhance unit test * - enhance unit test * mock Co-authored-by: rot1024 <aayhrot@gmail.com>
* - send mail * enhancement * fix log
…th/reearth-backend into auth/signup # Conflicts: # go.mod # internal/adapter/http/user.go # internal/app/public.go # internal/infrastructure/mongo/mongodoc/user.go # internal/infrastructure/mongo/user.go # internal/usecase/repo/user.go # pkg/user/builder.go # pkg/user/user.go # pkg/user/user_test.go
rot1024
suggested changes
Dec 9, 2021
rot1024
suggested changes
Dec 10, 2021
rot1024
approved these changes
Dec 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo