This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/authentication-system #83 +/- ##
=============================================================
Coverage ? 16.52%
=============================================================
Files ? 250
Lines ? 43361
Branches ? 0
=============================================================
Hits ? 7165
Misses ? 35180
Partials ? 1016 |
rot1024
suggested changes
Nov 29, 2021
rot1024
suggested changes
Dec 1, 2021
rot1024
approved these changes
Dec 6, 2021
@@ -104,7 +104,7 @@ func TestVerification_Expiration(t *testing.T) { | |||
|
|||
func TestVerification_IsExpired(t *testing.T) { | |||
tim, _ := time.Parse(time.RFC3339, "2021-03-16T04:19:57.592Z") | |||
tim2, _ := time.Parse(time.RFC3339, "2022-03-16T04:19:57.592Z") | |||
tim2 := time.Now().Add(time.Hour * 24) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for now but also remember this way:
var timeNow = time.Now
func hoge() {
now := timeNow() // instead of time.Now()
}
func Test_hoge() {
now := time.Time{...}
timeNow = func () time.Time {
return now
}
// test
}
NOTE: t.Parallel()
is not supported
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
create email content
How I tested
Which point I want you to review particularly
Memo