Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: user verification #83

Merged
merged 11 commits into from
Dec 6, 2021
Merged

Conversation

mimoham24
Copy link
Contributor

Overview

What I've done

What I haven't done

create email content

How I tested

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (feat/authentication-system@2632fe9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             feat/authentication-system      #83   +/-   ##
=============================================================
  Coverage                              ?   16.52%           
=============================================================
  Files                                 ?      250           
  Lines                                 ?    43361           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     7165           
  Misses                                ?    35180           
  Partials                              ?     1016           

internal/infrastructure/mongo/mongodoc/user.go Outdated Show resolved Hide resolved
pkg/user/verification.go Outdated Show resolved Hide resolved
pkg/user/verification.go Outdated Show resolved Hide resolved
pkg/user/verification.go Outdated Show resolved Hide resolved
pkg/user/verification_test.go Outdated Show resolved Hide resolved
pkg/user/user_test.go Outdated Show resolved Hide resolved
pkg/user/builder.go Show resolved Hide resolved
internal/usecase/interfaces/user.go Outdated Show resolved Hide resolved
internal/infrastructure/mongo/mongodoc/user.go Outdated Show resolved Hide resolved
internal/app/public.go Outdated Show resolved Hide resolved
@mimoham24 mimoham24 requested a review from rot1024 November 30, 2021 13:10
internal/app/public.go Outdated Show resolved Hide resolved
internal/app/public.go Outdated Show resolved Hide resolved
pkg/user/user_test.go Outdated Show resolved Hide resolved
pkg/user/verification.go Outdated Show resolved Hide resolved
pkg/user/verification_test.go Outdated Show resolved Hide resolved
internal/adapter/http/user.go Outdated Show resolved Hide resolved
pkg/user/verification.go Outdated Show resolved Hide resolved
@mimoham24 mimoham24 requested a review from rot1024 December 2, 2021 14:25
@@ -104,7 +104,7 @@ func TestVerification_Expiration(t *testing.T) {

func TestVerification_IsExpired(t *testing.T) {
tim, _ := time.Parse(time.RFC3339, "2021-03-16T04:19:57.592Z")
tim2, _ := time.Parse(time.RFC3339, "2022-03-16T04:19:57.592Z")
tim2 := time.Now().Add(time.Hour * 24)
Copy link
Member

@rot1024 rot1024 Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for now but also remember this way:

var timeNow = time.Now

func hoge() {
  now := timeNow() // instead of time.Now()
}
func Test_hoge() {
	now := time.Time{...}
	timeNow = func () time.Time {
		return now
	}

	// test
}

NOTE: t.Parallel() is not supported

@mimoham24 mimoham24 merged commit 532423b into feat/authentication-system Dec 6, 2021
@mimoham24 mimoham24 deleted the auth/verfication branch December 6, 2021 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants