Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: return property with clusters data #89

Merged
merged 13 commits into from
Dec 17, 2021
Merged

Conversation

issmail-basel
Copy link
Contributor

Overview

  • Cluster property to be object
  • Return Clusters data with published API
  • Change manifest data

Which point I want you to review particularly

Code clarity

@issmail-basel issmail-basel changed the title Refactor/cluster changes feat: return property with clusters data Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #89 (ec742bc) into main (c4fb9a5) will decrease coverage by 0.02%.
The diff coverage is 15.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   32.28%   32.25%   -0.03%     
==========================================
  Files         292      292              
  Lines       18773    18812      +39     
==========================================
+ Hits         6060     6067       +7     
- Misses      11907    11933      +26     
- Partials      806      812       +6     
Impacted Files Coverage Δ
internal/adapter/gql/gqlmodel/convert_scene.go 0.00% <0.00%> (ø)
internal/adapter/gql/resolver_mutation_scene.go 0.00% <0.00%> (ø)
internal/adapter/gql/resolver_scene.go 0.00% <0.00%> (ø)
internal/usecase/interactor/scene.go 0.00% <0.00%> (ø)
pkg/plugin/manifest/parser_translation.go 61.84% <0.00%> (-13.97%) ⬇️
pkg/scene/builder/encoder.go 92.85% <ø> (ø)
pkg/scene/cluster_list.go 85.71% <40.00%> (-9.94%) ⬇️
pkg/scene/builder/scene.go 85.71% <44.44%> (-5.47%) ⬇️
pkg/scene/scene.go 95.83% <100.00%> (+0.08%) ⬆️

@rot1024 rot1024 changed the title feat: return property with clusters data fix: return property with clusters data Dec 17, 2021
@rot1024 rot1024 merged commit 1b99c6d into main Dec 17, 2021
@rot1024 rot1024 deleted the refactor/cluster-changes branch December 17, 2021 05:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants