Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: cast values, rename value.OptionalValue #93

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix: cast values, rename value.OptionalValue #93

merged 1 commit into from
Dec 21, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Dec 21, 2021

  • When exporting a scene, the values of some properties linked to the dataset would become null. This has been fixed.
  • pkg/value/OptionalValue has been renamed to Optional.
  • pkg/value/Value.Cast method has been added to allow type conversion of values. Also, some type conversions such as string to URL and URL to string are newly supported.

@rot1024 rot1024 enabled auto-merge (squash) December 21, 2021 07:21
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #93 (b79260a) into main (1b99c6d) will increase coverage by 0.36%.
The diff coverage is 72.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   32.25%   32.61%   +0.36%     
==========================================
  Files         292      292              
  Lines       18812    18882      +70     
==========================================
+ Hits         6067     6159      +92     
+ Misses      11933    11915      -18     
+ Partials      812      808       -4     
Impacted Files Coverage Δ
pkg/dataset/value.go 13.40% <0.00%> (-1.38%) ⬇️
pkg/value/latlngheight.go 21.42% <0.00%> (-4.66%) ⬇️
pkg/value/url.go 0.00% <0.00%> (ø)
pkg/value/latlng.go 33.33% <25.00%> (+6.06%) ⬆️
pkg/property/value.go 35.05% <92.30%> (+20.60%) ⬆️
pkg/dataset/value_optional.go 88.37% <100.00%> (+1.88%) ⬆️
pkg/property/merged.go 78.10% <100.00%> (-0.63%) ⬇️
pkg/property/value_dataset.go 100.00% <100.00%> (ø)
pkg/property/value_optional.go 95.34% <100.00%> (+0.75%) ⬆️
pkg/value/bool.go 66.66% <100.00%> (+66.66%) ⬆️
... and 9 more

@rot1024 rot1024 disabled auto-merge December 21, 2021 07:27
@rot1024 rot1024 merged commit ba4b18f into main Dec 21, 2021
@rot1024 rot1024 deleted the fix-value branch December 21, 2021 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant