Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): init worker app with multi-module workspaces #112

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented Jul 20, 2022

What

  • Create worker dir
  • Introduce multi-module workspaces so that we can have multiple modules even in the same workspace
  • Add Dockerfile
  • Add a simple server which returns "hello world"

Why

  • Since Go1.18 supports the multi-module workspaces feature which allows us to have multiple modules under a single workspace though we couldn't do that and were forced to have a hacky way, I've introduced that to take the full advantage of mono-repo.

Point of Review

  • If there is any problem with directory structure, Dockerfile, etc

Things you don't need to review

  • The implementation of a simple server since it's a temporary development
  • GitHub actions workflow file will be implemented later

@HideBa HideBa self-assigned this Jul 20, 2022
@HideBa HideBa requested a review from rot1024 as a code owner July 20, 2022 02:09
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's time to use go workspace!

worker/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: rot1024 <aayhrot@gmail.com>
@HideBa HideBa merged commit 4cd744b into feat/async-upload-main Jul 20, 2022
@HideBa HideBa deleted the feat/setup-worker branch July 20, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants