Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Implement from domain models to Adapter on the public #267

Merged
merged 10 commits into from
Oct 7, 2022

Conversation

gop50k
Copy link
Contributor

@gop50k gop50k commented Oct 6, 2022

Overview

Implementation of Public APIs
From domain models to Adapter, implemented in project and model.

Ticket

#28

rot1024 and others added 2 commits October 6, 2022 12:47
Co-authored-by: Go Nakagawa <gop50k@users.noreply.github.com>
@gop50k gop50k self-assigned this Oct 6, 2022
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for reearth-cms canceled.

Name Link
🔨 Latest commit 208bd54
🔍 Latest deploy log https://app.netlify.com/sites/reearth-cms/deploys/633fec045df3da00094b61f4

@github-actions github-actions bot added the server label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #267 (208bd54) into main (e78bc50) will increase coverage by 64.12%.
The diff coverage is 56.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #267       +/-   ##
==========================================
+ Coverage   0.00%   64.12%   +64.12%     
==========================================
  Files        179      117       -62     
  Lines       9306     6508     -2798     
  Branches      45        0       -45     
==========================================
+ Hits           0     4173     +4173     
+ Misses      9306     2135     -7171     
- Partials       0      200      +200     
Flag Coverage Δ
server 64.12% <56.25%> (?)
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/internal/adapter/gql/gqlmodel/convert_project.go 0.00% <0.00%> (ø)
server/internal/usecase/interactor/model.go 25.69% <0.00%> (ø)
server/pkg/project/project.go 93.65% <20.00%> (ø)
...ver/internal/adapter/gql/gqlmodel/convert_model.go 100.00% <100.00%> (ø)
server/internal/usecase/interactor/project.go 78.72% <100.00%> (ø)
server/pkg/model/builder.go 100.00% <100.00%> (ø)
server/pkg/project/builder.go 100.00% <100.00%> (ø)
server/pkg/project/publication.go 100.00% <100.00%> (ø)
.../organisms/Settings/MyIntegrationDetails/index.tsx
...ts/organisms/Project/Content/ContentList/index.tsx
... and 293 more

@gop50k gop50k marked this pull request as ready for review October 6, 2022 09:36
@gop50k gop50k requested a review from rot1024 as a code owner October 6, 2022 09:36
@gop50k gop50k changed the title feat(server): add domain models to publication feat(server): Implement from domain models to Adapter on the public Oct 6, 2022
@gop50k gop50k requested a review from HideBa October 6, 2022 09:38
server/internal/adapter/gql/resolver_mutation_model.go Outdated Show resolved Hide resolved
server/internal/adapter/gql/resolver_mutation_model.go Outdated Show resolved Hide resolved
server/internal/usecase/interactor/model.go Outdated Show resolved Hide resolved
server/pkg/model/model_test.go Outdated Show resolved Hide resolved
server/pkg/model/model_test.go Outdated Show resolved Hide resolved
server/pkg/model/model_test.go Outdated Show resolved Hide resolved
server/pkg/model/model_test.go Outdated Show resolved Hide resolved
server/internal/adapter/gql/resolver_mutation_model.go Outdated Show resolved Hide resolved
@gop50k gop50k removed the request for review from HideBa October 7, 2022 04:57
@gop50k gop50k merged commit 6ff9a84 into main Oct 7, 2022
@gop50k gop50k deleted the feature/publication_domain_models branch October 7, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants