fix(engine):change type of sheet_name from Expr to String

reearth · Oct 14, 2024 · 917cd44 · 917cd44
1 parent 741f85d
commit 917cd44
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/engine/docs/mdbook/src/action.md b/engine/docs/mdbook/src/action.md
@@ -1378,7 +1378,7 @@ Writes features to a file
         "sheetName": {
           "anyOf": [
             {
-              "$ref": "#/definitions/Expr"
+              "type": "string"
             },
             {
               "type": "null"

diff --git a/engine/runtime/action-sink/src/file/excel.rs b/engine/runtime/action-sink/src/file/excel.rs
@@ -9,14 +9,14 @@ use reearth_flow_storage::resolve::StorageResolver;
 
 use reearth_flow_common::uri::Uri;
 
-use reearth_flow_types::{AttributeValue, Expr, Feature};
+use reearth_flow_types::{AttributeValue, Feature};
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, Debug, Clone, JsonSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct ExcelWriterParam {
-    pub(super) sheet_name: Option<Expr>,
+    pub(super) sheet_name: Option<String>,
 }
 
 pub(super) fn write_excel(
@@ -30,8 +30,8 @@ pub(super) fn write_excel(
 
     let sheet_name = params
         .sheet_name
-        .as_ref()
-        .map_or("Sheet1".to_string(), Expr::to_string);
+        .clone()
+        .unwrap_or_else(|| "Sheet1".to_string());
     worksheet
         .set_name(sheet_name)
         .map_err(crate::errors::SinkError::file_writer)?;

diff --git a/engine/schema/actions.json b/engine/schema/actions.json
@@ -1384,7 +1384,7 @@
               "sheetName": {
                 "anyOf": [
                   {
-                    "$ref": "#/definitions/Expr"
+                    "type": "string"
                   },
                   {
                     "type": "null"