fix(engine): remove unused routing ports from actions and update asse…

…t download logic
reearth · Dec 11, 2024 · 9330206 · 9330206
1 parent 908fab6
commit 9330206
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 40 deletions.
diff --git a/engine/docs/mdbook/src/action.md b/engine/docs/mdbook/src/action.md
@@ -2078,7 +2078,6 @@ Action for first port forwarding for sub-workflows.
 }
 ```
 ### Input Ports
-* routingPort
 ### Output Ports
 * default
 ### Category
@@ -2336,7 +2335,6 @@ Action for last port forwarding for sub-workflows.
 ### Input Ports
 * default
 ### Output Ports
-* routingPort
 ### Category
 * System
 

diff --git a/engine/runtime/runtime/src/node.rs b/engine/runtime/runtime/src/node.rs
@@ -411,7 +411,7 @@ impl ProcessorFactory for InputRouterFactory {
     }
 
     fn get_input_ports(&self) -> Vec<Port> {
-        vec![Port::new(ROUTING_PARAM_KEY)]
+        vec![]
     }
 
     fn get_output_ports(&self) -> Vec<Port> {
@@ -497,7 +497,7 @@ impl ProcessorFactory for OutputRouterFactory {
     }
 
     fn get_output_ports(&self) -> Vec<Port> {
-        vec![Port::new(ROUTING_PARAM_KEY)]
+        vec![]
     }
 
     fn build(

diff --git a/engine/schema/actions.json b/engine/schema/actions.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/schema/actions_en.json b/engine/schema/actions_en.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/schema/actions_es.json b/engine/schema/actions_es.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/schema/actions_fr.json b/engine/schema/actions_fr.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/schema/actions_ja.json b/engine/schema/actions_ja.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/schema/actions_zh.json b/engine/schema/actions_zh.json
@@ -2086,9 +2086,7 @@
         }
       },
       "builtin": true,
-      "inputPorts": [
-        "routingPort"
-      ],
+      "inputPorts": [],
       "outputPorts": [
         "default"
       ],
@@ -2347,9 +2345,7 @@
       "inputPorts": [
         "default"
       ],
-      "outputPorts": [
-        "routingPort"
-      ],
+      "outputPorts": [],
       "categories": [
         "System"
       ]

diff --git a/engine/worker/src/asset.rs b/engine/worker/src/asset.rs
@@ -11,6 +11,9 @@ pub(crate) async fn download_asset(
     asset: &Asset,
     download_path: &Uri,
 ) -> crate::errors::Result<()> {
+    if asset.is_empty() {
+        return Ok(());
+    }
     let uris = asset
         .files
         .iter()

diff --git a/engine/worker/src/types/metadata.rs b/engine/worker/src/types/metadata.rs
@@ -23,6 +23,12 @@ pub struct Asset {
     pub files: Vec<String>,
 }
 
+impl Asset {
+    pub fn is_empty(&self) -> bool {
+        self.files.is_empty()
+    }
+}
+
 #[derive(Serialize, Deserialize, Debug, JsonSchema)]
 #[serde(rename_all = "camelCase")]
 pub struct AssetFile {