Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add checkout build action #508

Merged
merged 1 commit into from
Sep 17, 2024
Merged

ci: add checkout build action #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,8 @@ jobs:
runs-on: ubuntu-latest
if: ${{ !failure() && needs.ci-api.result == 'success' && github.event_name == 'push' && (github.ref_name == 'main' || github.ref_name == 'release' || startsWith(github.ref_name, 'release/')) }}
steps:
- uses: actions/checkout@v4

Comment on lines +139 to +140
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying fetch-depth in the checkout step

By default, actions/checkout@v4 performs a shallow clone with fetch-depth: 1. If your build_deploy_api action relies on git history, tags, or multiple commits (e.g., for versioning or changelog generation), you might need to set fetch-depth: 0 to fetch the entire history.

Apply this diff to specify fetch-depth:

    - uses: actions/checkout@v4
+     with:
+       fetch-depth: 0
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
fetch-depth: 0

- uses: ./.github/actions/build_deploy_api
with:
sha_short: ${{ needs.ci-collect-info.outputs.sha_short }}
Expand All @@ -152,6 +154,8 @@ jobs:
runs-on: ubuntu-latest
if: ${{ !failure() && needs.ci-ui.result == 'success' && github.event_name == 'push' && (github.ref_name == 'main' || github.ref_name == 'release' || startsWith(github.ref_name, 'release/')) }}
steps:
- uses: actions/checkout@v4

Comment on lines +157 to +158
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying fetch-depth in the checkout step

Similar to the build-api job, if your build_deploy_ui action requires access to the full git history or tags, consider setting fetch-depth: 0 to ensure all necessary information is available.

Apply this diff to specify fetch-depth:

    - uses: actions/checkout@v4
+     with:
+       fetch-depth: 0
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v4
with:
fetch-depth: 0

- uses: ./.github/actions/build_deploy_ui
with:
sha_short: ${{ needs.ci-collect-info.outputs.sha_short }}
Expand Down
Loading