Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engine): bump external crates for engine #523

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

miseyu
Copy link
Contributor

@miseyu miseyu commented Sep 23, 2024

Overview

What I've done

What I haven't done

How I tested

Screenshot

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • New Features

    • Updated schema references in various YAML configuration files to point to a new location, improving organization and potentially enhancing validation processes.
  • Bug Fixes

    • Removed outdated or unnecessary dependencies from multiple Cargo.toml files, streamlining the project's dependency management.
  • Documentation

    • Updated schema URLs in YAML files to reflect the new structure, ensuring accurate references for workflows.

@miseyu miseyu self-assigned this Sep 23, 2024
@miseyu miseyu requested a review from a team as a code owner September 23, 2024 13:25
Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Walkthrough

The pull request introduces several modifications primarily focused on updating dependency versions in various Cargo.toml files across the project. Additionally, several dependencies have been removed from workspace configurations, streamlining the project’s dependency management. Changes to YAML schema references in workflow files are also included, indicating a shift in schema organization.

Changes

File Path Change Summary
engine/Cargo.toml Updated versions for multiple dependencies: bytes, clap, opendal, quick-xml, rust_xlsxwriter, thiserror.
engine/runtime/action-log/Cargo.toml Removed tokio-stream.workspace from the workspace configuration.
engine/runtime/action-plateau-processor/Cargo.toml Removed dependencies: Inflector, csv, tracing-subscriber, pretty_assertions.
engine/runtime/action-processor/Cargo.toml Removed opentelemetry.workspace and pretty_assertions.workspace.
engine/runtime/action-sink/Cargo.toml Added dependencies: flate2, hashbrown, prost. Removed: bincode, tracing-subscriber.
engine/runtime/action-source/Cargo.toml Removed dependencies: opentelemetry, tracing-subscriber, pretty_assertions.
engine/runtime/common/Cargo.toml Removed multiple workspace dependencies: nusamai-mvt, nusamai-projection, petgraph, tokio-stream, tokio-util, tracing, tracing-subscriber.
engine/runtime/eval-expr/Cargo.toml Removed workspace declarations for tracing and tracing-subscriber.
engine/runtime/examples/Cargo.toml Removed pretty_assertions.workspace.
engine/runtime/examples/plateau/*.yml Updated schema references from schema/workflow.json to engine/schema/workflow.json.
engine/runtime/geometry/Cargo.toml Removed dependencies: nusamai-citygml, nalgebra-glm, strum, tracing, tracing-subscriber.
engine/runtime/macros/Cargo.toml Removed heck dependency.
engine/runtime/runner/Cargo.toml Removed opentelemetry.workspace and pretty_assertions.workspace.
engine/runtime/runtime/Cargo.toml Removed opentelemetry.workspace, tracing-subscriber.workspace, and pretty_assertions.workspace.
engine/runtime/state/Cargo.toml Removed serde_with, tracing-subscriber.
engine/runtime/storage/Cargo.toml Removed serde_with, tempfile, tokio-stream, tracing-subscriber.
engine/runtime/storage/src/operator.rs Changed instantiation of MetricsLayer to MetricsLayer::default().
engine/runtime/telemetry/Cargo.toml Removed serde_json.workspace.
engine/runtime/tests/Cargo.toml Removed pretty_assertions and tracing-subscriber from workspace dependencies.
engine/runtime/tests/fixture/workflow/feature/merger.yaml Updated schema reference from schema/workflow.json to engine/schema/workflow.json.
engine/runtime/types/Cargo.toml Removed reearth-flow-action-log, reearth-flow-storage, async-trait, async_zip, strum, tokio-stream, tracing-subscriber.

Possibly related PRs

Suggested labels

worker

Poem

🐇 In the garden where dependencies grow,
Versions updated, a delightful show!
With schemas shifting, paths anew,
A cleaner workspace, for me and you.
Hopping along, we celebrate this cheer,
In the world of code, it's a joyful year! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for reearth-flow canceled.

Name Link
🔨 Latest commit bee43a1
🔍 Latest deploy log https://app.netlify.com/sites/reearth-flow/deploys/66f16cc2eb47990008186e54

@miseyu
Copy link
Contributor Author

miseyu commented Sep 23, 2024

@coderabbitai summary

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Actions performed

Summary regeneration triggered.

@miseyu miseyu merged commit 8e52d2f into main Sep 23, 2024
17 checks passed
@miseyu miseyu deleted the chore/bump-engine-crates branch September 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant