ci: add build push worker docker workflow & dep upgrade #759
Conversation
|
Warning Rate limit exceeded@pyshx has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 16 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis pull request focuses on updating GitHub Actions workflow files across multiple components (API, UI, WebSocket, and Worker) by upgrading various action versions. The changes primarily involve incrementing versions of actions like Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for reearth-flow canceled.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
.github/workflows/docker_push_worker.yml (1)
47-71: Improve shell script robustness and security.The shell script for determining build options could be improved for better robustness:
run: | - TAG="${{ inputs.new_tag_short != 'blank' && inputs.new_tag_short || '' }}" - NAME="${{ inputs.name }}" - SHA="${{ inputs.sha_short }}" + TAG="${{ inputs.new_tag_short != 'blank' && inputs.new_tag_short || '' }}" + NAME="${{ inputs.name }}" + SHA="${{ inputs.sha_short }}" + { + echo "platforms=${PLATFORMS}" + echo "version=${VERSION}" + echo "tags=${TAGS}" + } >> "$GITHUB_OUTPUT"🧰 Tools
🪛 actionlint (1.7.4)
47-47: shellcheck reported issue in this script: SC2129:style:21:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:21:32: Double quote to prevent globbing and word splitting
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:22:28: Double quote to prevent globbing and word splitting
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:23:22: Double quote to prevent globbing and word splitting
(shellcheck)
.github/workflows/build_deploy_api.yml (1)
35-35: Consider using a more specific Go version.For reproducible builds, consider specifying the exact Go version (e.g., "1.21.5") instead of just "1.21".
.github/workflows/build_deploy_websocket.yml (1)
Line range hint
33-37: Consider updating the Rust toolchain action.The actions-rs/toolchain@v1 action is relatively old. Consider using rust-lang/setup-rust-action which is more actively maintained.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/build_deploy_api.yml(6 hunks).github/workflows/build_deploy_ui.yml(5 hunks).github/workflows/build_deploy_websocket.yml(5 hunks).github/workflows/ci_api.yml(2 hunks).github/workflows/docker_push_worker.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/docker_push_worker.yml
47-47: shellcheck reported issue in this script: SC2129:style:21:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:21:32: Double quote to prevent globbing and word splitting
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:22:28: Double quote to prevent globbing and word splitting
(shellcheck)
47-47: shellcheck reported issue in this script: SC2086:info:23:22: Double quote to prevent globbing and word splitting
(shellcheck)
.github/workflows/build_deploy_ui.yml
31-31: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: ci-api / ci-api-lint
- GitHub Check: ci-api / ci-api-test
🔇 Additional comments (3)
.github/workflows/docker_push_worker.yml (1)
73-84: LGTM! Good security practices in Docker build configuration.The Docker build configuration includes important security features:
- Provenance and SBOM generation enabled
- Build caching properly configured
- Multi-platform build support
.github/workflows/build_deploy_api.yml (1)
Line range hint
119-129: LGTM! Enhanced security with SBOM and provenance.Good addition of security features:
- Software Bill of Materials (SBOM) generation
- Build provenance for supply chain security
.github/workflows/ci_api.yml (1)
13-13: LGTM! Action version upgrades are appropriate.The upgrades to actions/checkout@v4 and actions/setup-go@v5 are good improvements that bring in the latest features and security fixes.
Also applies to: 37-37
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 'lts/*' | ||
| node-version: "lts/*" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Update actions/setup-node to latest version.
The current setup-node@v3 action may have compatibility issues with the runner. Consider upgrading to setup-node@v4.
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: "lts/*"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: actions/setup-node@v3 | |
| with: | |
| node-version: 'lts/*' | |
| node-version: "lts/*" | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: "lts/*" |
🧰 Tools
🪛 actionlint (1.7.4)
31-31: the runner of "actions/setup-node@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
pyshx
changed the title
pyshx
changed the title
…eearth-flow into ci/add-deploy-worker-workflowd
Overview
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo
Summary by CodeRabbit
Chores
Infrastructure