feat(web): add textarea field in property field #1133
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
airslice
changed the title
WalkthroughThe update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 15.18% 14.47% -0.71%
==========================================
Files 642 567 -75
Lines 63207 60509 -2698
Branches 792 631 -161
==========================================
- Hits 9600 8761 -839
+ Misses 53607 51748 -1859
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| ) : schema.ui === "multiline" ? ( | ||
| <TextareaField | ||
| key={schema.id} | ||
| commonTitle={schema.name} | ||
| value={(value as string) ?? ""} | ||
| description={schema.description} | ||
| onBlur={handleChange} | ||
| /> |
There was a problem hiding this comment.
Consider using onChange instead of onBlur for the TextareaField.
The TextareaField is correctly integrated to handle multiline inputs. However, using onBlur to handle changes might delay feedback until the user clicks away from the textarea. This could affect user experience, especially in forms where immediate feedback or validation is expected.
Consider changing the event handler to onChange to provide immediate feedback as the user types:
- <TextareaField
- key={schema.id}
- commonTitle={schema.name}
- value={(value as string) ?? ""}
- description={schema.description}
- onBlur={handleChange}
- />
+ <TextareaField
+ key={schema.id}
+ commonTitle={schema.name}
+ value={(value as string) ?? ""}
+ description={schema.description}
+ onChange={handleChange}
+ />Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ) : schema.ui === "multiline" ? ( | |
| <TextareaField | |
| key={schema.id} | |
| commonTitle={schema.name} | |
| value={(value as string) ?? ""} | |
| description={schema.description} | |
| onBlur={handleChange} | |
| /> | |
| ) : schema.ui === "multiline" ? ( | |
| <TextareaField | |
| key={schema.id} | |
| commonTitle={schema.name} | |
| value={(value as string) ?? ""} | |
| description={schema.description} | |
| onChange={handleChange} | |
| /> |
Overview
It was missing.
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
PropertyFieldcomponent, allowing users to enter longer text entries.TextareaFieldcomponent, enhancing the versatility of text input options.