Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): fix typo on screen when no asset appears and in settings dropdown #1269

Merged
merged 5 commits into from
Nov 24, 2024

Conversation

mulengawilfred
Copy link
Contributor

@mulengawilfred mulengawilfred commented Nov 21, 2024

Overview

Fixed a small typo in the text copy when no asset has been uploaded yet

What I've done

Before:
Screenshot 2024-11-21 at 3 17 13 PM
After:
Screenshot 2024-11-21 at 3 22 30 PM

Screenshot 2024-11-22 at 10 34 17 AM Screenshot 2024-11-22 at 10 34 26 AM

What I haven't done

How I tested

Which point I want you to review particularly

Memo

We have a ticket to go through the text copy but I thought just incase

Summary by CodeRabbit

  • New Features

    • Updated user interface text for improved clarity in the Assets Manager component.
  • Bug Fixes

    • Corrected capitalization in various phrases, including "No asset has been uploaded yet," "Switch workspace," and "Log out" across English and Japanese translations for consistency.
  • Documentation

    • Enhanced clarity and consistency in localization for various user interface strings in Japanese.

Copy link

coderabbitai bot commented Nov 21, 2024

Walkthrough

The changes in this pull request involve minor textual adjustments across multiple files related to user interface text and localization. Specifically, phrases such as "No Asset has been uploaded yet" and "Switch Workspace" have been modified to "No asset has been uploaded yet" and "Switch workspace," respectively, to correct capitalization. These modifications are purely cosmetic and do not affect the functionality or logic of the application.

Changes

File Path Change Summary
web/src/beta/features/AssetsManager/index.tsx Updated text in ManagerEmptyContent from "No Asset has been uploaded yet" to "No asset has been uploaded yet."
web/src/services/i18n/translations/en.yml Changed "No Asset has been uploaded yet" to "No asset has been uploaded yet" and adjusted other phrases for capitalization consistency.
web/src/services/i18n/translations/ja.yml Updated "No Asset has been uploaded yet" to "No asset has been uploaded yet" and refined other phrases for clarity.
web/src/beta/features/Dashboard/LeftSidePanel/profile.tsx Changed "Switch Workspace" to "Switch workspace" and "Log Out" to "Log out" for menu item titles.
web/src/beta/hooks/useWorkspaceManagementMenu.ts Modified titles in workspaceManagementMenu from title case to sentence case for consistency.

Possibly related PRs

Suggested reviewers

  • mkumbobeaty
  • airslice
  • ZTongci

🐰 In the meadow, where words take flight,
A change in the text, oh what a sight!
"No asset," it says, with a lowercase cheer,
Bringing clarity close, making meanings clear.
Hopping along, we celebrate this day,
For words, like bunnies, love to play! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 25492f3
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/674392a03787230008ecc28f
😎 Deploy Preview https://deploy-preview-1269--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 21, 2024
@mulengawilfred mulengawilfred changed the title chore(web): fix typo on screen when no asset appears chore(web): fix typo on screen when no asset appears and in settings dropdown Nov 22, 2024
@mulengawilfred mulengawilfred changed the title chore(web): fix typo on screen when no asset appears and in settings dropdown refactor(web): fix typo on screen when no asset appears and in settings dropdown Nov 22, 2024
@mulengawilfred mulengawilfred merged commit 43b1a48 into main Nov 24, 2024
13 checks passed
@mulengawilfred mulengawilfred deleted the chore/fix-typo branch November 24, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants