Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade Goreleaser to use v2 configuration #1309

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

KeisukeYamashita
Copy link
Contributor

@KeisukeYamashita KeisukeYamashita commented Dec 12, 2024

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • New Features

    • Enhanced versioning specificity for the server build and release process.
    • Improved tagging logic for Docker images.
    • Added new workflow input for short new tags.
  • Bug Fixes

    • Restructured changelog handling to ensure proper documentation of changes.
  • Documentation

    • Updated project name to "reearth" in the release configuration.
  • Chores

    • Added a hook for go mod tidy to streamline dependencies management.

Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita KeisukeYamashita self-assigned this Dec 12, 2024
Copy link

coderabbitai bot commented Dec 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the workflow configuration for building and releasing a server, specifically in the .github/workflows/build_server.yml and server/.goreleaser.yml files. Key changes include updating version constraints, enhancing tagging logic, and restructuring the build and release process. New inputs and hooks are added, and existing configurations are refined to improve versioning and output formatting. The project name is set to "reearth," and the handling of changelogs is altered.

Changes

File Change Summary
.github/workflows/build_server.yml - Updated goreleaser/goreleaser-action version from latest to ~> v2.
- Added --clean flag to args.
- Modified logic for TAGS variable based on TAG value.
- Added new input new_tag_short, modified existing inputs.
server/.goreleaser.yml - Updated version to 2 and set project name to reearth.
- Added go mod tidy hook.
- Specified main command as ./cmd/reearth.
- Changed changelog handling from skip: true to disable: true.
- Updated snapshot name template.

Possibly related PRs

  • ci: remove --rm-dist from Goreleaser arguments #1308: The changes in this PR involve modifications to the .github/workflows/build_server.yml file, specifically related to the args parameter in the GoReleaser step, which aligns with the changes made in the main PR regarding the workflow configuration for building and releasing the server.

Suggested reviewers

  • rot1024

Poem

🐰 In the meadow where code does play,
Changes bloom like flowers in May.
With tags and versions, we hop along,
Building our server, where we belong!
A tidy mod, a project named right,
In the world of code, we take flight! 🌼


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d133f2f and 14ab8e8.

📒 Files selected for processing (2)
  • .github/workflows/build_server.yml (1 hunks)
  • server/.goreleaser.yml (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit 14ab8e8
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/675abfe72554250008c251e1

@@ -38,8 +38,8 @@ jobs:
uses: goreleaser/goreleaser-action@v4
with:
distribution: goreleaser
version: latest
args: release ${{ inputs.new_tag == 'blank' && '--snapshot' || '' }}
version: ~> v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed Goreleaser's recommendation.

@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review December 12, 2024 10:55
@KeisukeYamashita KeisukeYamashita changed the title ci: upgrade goreleaser to use v2 configuration ci: upgrade Goreleaser to use v2 configuration Dec 12, 2024
@KeisukeYamashita KeisukeYamashita merged commit 29bc640 into main Dec 12, 2024
16 checks passed
@KeisukeYamashita KeisukeYamashita deleted the bump-goreleaser-yaml-to-v2 branch December 12, 2024 10:55
ZTongci pushed a commit that referenced this pull request Dec 17, 2024
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant