Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): layer style boolean selector field doesn't work properly with string value #1322

Merged
merged 4 commits into from
Dec 24, 2024
Merged

fix(web): layer style boolean selector field doesn't work properly with string value #1322

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98564a5
fix: check value in type of string
airslice Dec 20, 2024
6f4c7cd
refactor: use lowercase
airslice Dec 20, 2024
a4a4352
Merge branch 'main' into fix/layer-style-boolean-selector-value
airslice Dec 24, 2024
12bef48
Merge branch 'main' into fix/layer-style-boolean-selector-value
airslice Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...Editor/Map/LayerStylePanel/Editor/StyleInterface/StyleNode/Field/BooleanSelectorInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,22 @@ const booleanOptions = [
];

type Props = {
value: boolean | undefined;
value: boolean | string | undefined;
onChange: (value: boolean | undefined) => void;
};

const BooleanSelectorInput: FC<Props> = ({ value, onChange }) => {
return (
<Selector
value={value === true ? "true" : value === false ? "false" : ""}
value={
value === true ||
(typeof value === "string" && value.toLowerCase() === "true")
? "true"
: value === false ||
(typeof value === "string" && value.toLowerCase() === "false")
? "false"
: ""
}
airslice marked this conversation as resolved.
Show resolved Hide resolved
options={booleanOptions}
onChange={(v) =>
onChange(v === "true" ? true : v === "false" ? false : undefined)
Expand Down
Loading