-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): add missing "extended" prop to plugin #1325
Conversation
WalkthroughThe pull request introduces an Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
web/src/beta/features/PluginPlayground/Code/hook.ts (1)
21-21
: Add clarity on the “extended” property usage.Consider adding a short comment in the type definition to describe how this property should be used and its expected effects in the widget’s behavior.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
web/src/beta/features/PluginPlayground/Code/hook.ts
(3 hunks)
🔇 Additional comments (2)
web/src/beta/features/PluginPlayground/Code/hook.ts (2)
148-149
: Good use of optional chaining and fallback.
This approach gracefully handles cases where “extended” is omitted from the YAML by defaulting to false.
168-169
: Property placement looks correct.
Including the “extended” flag in the widget object is consistent with how other widget properties are stored and passed along.
Overview
Adding this prop so that its possible to use "extended" feature for plugin.
What I've done
After applying the change in this PR, I tested my changing the values in
reearth.yml
file in theMy Plugin
folder in the Plugin Playground as belowIn the changes above, the
extended: true
value is added and thearea
is changed tomiddle
. I also made these changes in thedemo-widget.js
file to test:And to the
wrapper
class, I addedheight: 100%;
Below is a screenshot of the change in plugin playground

And here is a screenshot of the change in editor. I noticed that on editor, the plugin didn't take the full height on inital load but only after re-sizing the browser screen (i.e opening the browser console )

What I haven't done
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
extended
property to enhance widget configuration options.extended
state without affecting existing functionality.