feat(servr): add MultiLineString Valid

[hexaforce]

Overview

added validation for MultiLineString

What I've done

The validation for MultiLineString was missing, so I will add it.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

• Bug Fixes

  • Enhanced GeoJSON validation for MultiLineString geometries
  • Improved feature validation process to ensure proper data integrity

• Refactor

  • Removed unused commented-out validation function
  • Strengthened error checking for feature validation

[coderabbitai]

Walkthrough

The pull request focuses on improving the GeoJSON validation logic in the NLSLayer struct within the nlslayer.go file. The changes primarily involve adding validation for MultiLineString geometries, ensuring that each LineString contains at least two coordinates and that all coordinates are valid latitude and longitude values. The validation process has been enhanced to more strictly check feature validity, requiring both a non-nil feature and a nil error. An unused commented-out function validateBBox was also removed, simplifying the codebase.

Changes

File	Change Summary
server/internal/usecase/interactor/nlslayer.go	- Enhanced validateGeoJSONFeatureCollection and validateGeoJSONFeature functions - Added validation for MultiLineString geometries - Stricter feature validity checking - Removed commented-out validateBBox function

Possibly related PRs

• feat(server): update geojson custom library #1366: Changes related to transitioning to the orb library for handling geometrical features

Suggested labels

server

Suggested reviewers

• pyshx

Poem

🗺️ Validation's dance, a geometric delight,
MultiLineString now shines so bright!
Coordinates checked with rabbit-like care,
No invalid features shall slip through there.
GeoJSON's guardian, precise and clean,
A code refinement, a validation scene! 🐰

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37c75ff and 975d7f9.

📒 Files selected for processing (1)

• server/internal/usecase/interactor/nlslayer.go (2 hunks)

🔇 Additional comments (2)

server/internal/usecase/interactor/nlslayer.go (2)

1181-1181: LGTM! Robust feature validation.

The condition ensures both a non-nil feature and successful unmarshaling, which is a good defensive programming practice.

---

1243-1256: LGTM! Comprehensive MultiLineString validation.

The validation logic for MultiLineString is thorough and covers all necessary checks:

1. Non-empty MultiLineString array
2. Minimum coordinate requirement for each LineString
3. Valid latitude/longitude bounds for all coordinates

This implementation aligns well with the GeoJSON specification.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for reearth-web canceled.

Name	Link
🔨 Latest commit	6e2f3ec
🔍 Latest deploy log	https://app.netlify.com/sites/reearth-web/deploys/6799b6b205d5dd00080545f3