💥 Change deleted from string to Date
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a **BREAKING** change that will change the `deleted` field from
a `string` to a `Date`, which will let us set up a TTL index on it.
Although this change is technically breaking, it should be deployable
with no impact on Production, since we only ever query `deleted` using
the `$exists` operator.
In order to leverage the TTL index, we'll need to:
1. Deploy this change
2. Migrate all existing `deleted` fields to `Date`:
```js
db.collection.update(
{deleted: {$type: "string"}},
[{$set: {deleted: {$toDate: "$deleted"}}}]
)
```
3. Change the existing `deleted` index to TTL:
```js
db.runCommand({
collMod: '...',
index: {
name: 'deleted_1',
expireAfterSeconds: 2592000, // ~ 1 month
}
})
```
dawidreedsy
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BREAKING change that will change the
deletedfield from astringto aDate, which will let us set up a TTL index on it.Although this change is technically breaking, it should be deployable with no impact on Production, since we only ever query
deletedusing the$existsoperator.In order to leverage the TTL index, we'll need to:
deletedfields toDate:deletedindex to TTL: