-
Notifications
You must be signed in to change notification settings - Fork 79
bump schemars to 1.0 #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bump schemars to 1.0 #174
Conversation
|
Can we keep schemars 0.8 support while adding a separate Note: The test failures are fixed by #175. |
|
Oh yeah absolutely. An alternative I've been considering is to add support for ordered float over in the schemars crate. They provide support for many common crates, and use the dependency versioning scheme using features you've suggested. I'm okay with either approach. |
Does not work. Cannot be completed easily because `OrderedFloat` does not support schemars v1 yet reem/rust-ordered-float#174
Does not work. Cannot be completed easily because `OrderedFloat` does not support schemars v1 yet reem/rust-ordered-float#174
Does not work. Cannot be completed easily because `OrderedFloat` does not support schemars v1 yet reem/rust-ordered-float#174
|
@mdepta42 @mbrubeck I see that there is an |
|
Yeah, it would be nice to have that issue solved. As far as I can tell, we would need to:
I can look into both of these things this week. |
Bump version of schemars to recently released 1.0.
Changes incldue:
json_schemamacro.JsonSchematrait definition was changed, most notablyis_referenceablehas been changed toinline_schema(see and see)serde_json::Valueinternally seeI'm no expert at the schemars internals so everyone please feel free to correct / improve upon the current implementation.