Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/connecting sdk #6

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Feat/connecting sdk #6

merged 8 commits into from
Sep 16, 2024

Conversation

DenielGrin
Copy link
Contributor

@DenielGrin DenielGrin self-assigned this Sep 11, 2024
@DenielGrin DenielGrin marked this pull request as ready for review September 16, 2024 11:47
TorinAsakura
TorinAsakura requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-logic пожалуйста вынеси по конвенции и переименуй соответствующим образом, а то аж скулы подёргиваются

@DenielGrin
Copy link
Contributor Author

build-logic пожалуйста вынеси по конвенции и переименуй соответствующим образом, а то аж скулы подёргиваются

Переименова на buildConfig, чтобы сразу понимать, что плагин отвечает за конфигурацию сборки.
Есть вопрос по переносу - я никуда его не могу унести, он лежит на уровне всех модулей, так как все модули его используют

@TorinAsakura TorinAsakura merged commit 1bd4cb6 into master Sep 16, 2024
@TorinAsakura TorinAsakura deleted the feat/connecting-sdk branch September 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees

@DenielGrin DenielGrin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenielGrin @TorinAsakura