Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: unified lowercase not needed #113

Merged
merged 1 commit into from
Aug 27, 2024
Merged

nit: unified lowercase not needed #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions LDKNodeMonday/Extensions/String+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,4 @@ extension String {
return self.uppercased()
}

func lowercaseScheme() -> String {
guard let colonIndex = self.firstIndex(of: ":") else {
return self
}
let scheme = self[..<colonIndex].lowercased()
return scheme + self[colonIndex...]
}

}
1 change: 0 additions & 1 deletion LDKNodeMonday/View Model/Home/Receive/BIP21ViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class BIP21ViewModel: ObservableObject {
message: message,
expirySec: expirySecs
)
let unifiedLowercase = unified.lowercaseScheme()

DispatchQueue.main.async {
self.unified = unifiedLowercase
Expand Down
2 changes: 1 addition & 1 deletion LDKNodeMonday/View/Home/Send/AmountView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ extension AmountView {
let scanString = scanResult.string
let (_, extractedAmount, extractedPayment) =
scanString.extractPaymentInfo(spendableBalance: spendableBalance)
address = scanString.lowercaseScheme()
address = scanString
numpadAmount = extractedAmount
payment = extractedPayment

Expand Down
Loading