refactor: navigation, codescanner

[reez]

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I have formatted my code with swift-format per .swift-format file

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

Summary by CodeRabbit

• New Features
  • Enhanced navigation capabilities in the StartView and BitcoinView to improve user experience.
  • Added vibration feedback for successful scans in the CodeScannerView.
• Bug Fixes
  • Improved thread safety in onboarding completion logic to ensure UI responsiveness.
• Documentation
  • Updated previews to reflect new binding requirements for navigation paths.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to several Swift files within the LDKNodeMonday application. Key updates include the introduction of new binding parameters for navigation paths in the StartView and BitcoinView, ensuring these views can reflect external navigation states. Additionally, the onboarding logic in OnboardingViewModel has been adjusted to ensure UI updates occur on the main thread. The CodeScannerView in AddressView now includes a vibration feature upon successful scans, enhancing user feedback.

Changes

Files	Change Summary
LDKNodeMonday/App/LDKNodeMondayApp.swift	Updated StartView initialization to include a binding for navigationPath.
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift	Wrapped isOnboarding assignment in DispatchQueue.main.async for thread safety.
LDKNodeMonday/View/Home/BitcoinView.swift	Changed sendNavigationPath from @State to @Binding to reflect external navigation state.
LDKNodeMonday/View/Home/Send/AddressView.swift	Added shouldVibrateOnSuccess parameter to CodeScannerView initialization.
LDKNodeMonday/View/Home/StartView.swift	Introduced @Binding var navigationPath in StartView and updated BitcoinView instantiation accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant StartView
    participant BitcoinView
    participant OnboardingViewModel

    User->>StartView: Initialize
    StartView->>BitcoinView: Pass navigationPath
    BitcoinView->>User: Display Bitcoin options
    User->>OnboardingViewModel: Complete onboarding
    OnboardingViewModel->>OnboardingViewModel: Update isOnboarding on main thread

Loading

Poem

🐰 In the land of code where rabbits hop,
New paths of navigation make our hearts stop.
With Bitcoin views and onboarding cheer,
We celebrate changes that bring us near!
Hopping through updates, so fresh and bright,
Our app's now a wonder, a true delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.