UI - onboarding styling and colors #131
Conversation
WalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Learnings (1)LDKNodeMonday.xcodeproj/project.pbxproj (1)🔇 Additional comments (3)LDKNodeMonday.xcodeproj/project.pbxproj (3)
The new views (
While multiple LDKNode framework references exist, based on the past discussions and learnings, this might be intentional if you're using custom forks or managing different versions. Run the following script to analyze the framework references: ✅ Verification successfulBased on the script results and the learning from danielnordh that "Multiple LDKNode framework references in Multiple LDKNode framework references appear to be intentional The project contains three LDKNode framework references which is a known pattern when working with custom forks or different versions. This setup is supported by extensive and consistent LDKNode usage across 33 different files in the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for LDKNode framework references and their usage
# Search for LDKNode framework references
echo "LDKNode framework references:"
rg -A 2 "LDKNode in Frameworks"
# Search for custom LDKNode imports
echo "\nCustom LDKNode imports:"
rg "import.*LDKNode"
Length of output: 4907
Consider using consistent versions across LDKNode package references. There are two different versions of the LDKNode package being referenced:
This version inconsistency could lead to compatibility issues. Consider updating both references to use the same version: requirement = {
kind = exactVersion;
- version = 0.4.0;
+ version = 0.4.2;
};Additionally, consider using a version range to automatically receive security updates: requirement = {
- kind = exactVersion;
- version = 0.4.2;
+ kind = upToNextMinor;
+ minimumVersion = "0.4.2";
};⛔ Skipped due to learningsThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (3)
LDKNodeMonday/Assets.xcassets/AccentColor.colorset/Contents.json (1)
5-11: Consider using consistent hex notation for color components.The color definition looks good, but for better maintainability, consider using hexadecimal notation consistently across both color definitions.
"components" : { "alpha" : "1.000", - "blue" : "0.894", - "green" : "0.188", - "red" : "0.111" + "blue" : "0xE4", + "green" : "0x30", + "red" : "0x1C" }LDKNodeMonday/View/Home/OnboardingView.swift (2)
28-38: Add accessibility label for the wallet icon.While the styling looks good, consider adding an accessibility label to the image for better VoiceOver support.
Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) .foregroundColor(.accent) .frame(width: 150, height: 150, alignment: .center) + .accessibilityLabel("Monday Wallet Logo") .padding(40)
Line range hint
44-83: Consider responsive padding for different screen sizes.The fixed horizontal padding of 50 points might be too large on smaller devices. Consider using a more responsive approach.
-}.padding(.horizontal, 50) +}.padding(.horizontal, min(50, UIScreen.main.bounds.width * 0.15))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- LDKNodeMonday.xcodeproj/project.pbxproj (6 hunks)
- LDKNodeMonday/Assets.xcassets/AccentColor.colorset/Contents.json (2 hunks)
- LDKNodeMonday/View/Home/OnboardingView.swift (2 hunks)
🔇 Additional comments (1)
LDKNodeMonday/View/Home/OnboardingView.swift (1)
119-128: LGTM! Error handling implementation looks good.The alert implementation provides clear error feedback with proper dismissal handling.
| Button("Create wallet") { | ||
| viewModel.saveSeed() | ||
| isFirstTime = false | ||
| } label: { | ||
| Text("Start Node") | ||
| .bold() | ||
| .foregroundColor(Color(uiColor: UIColor.systemBackground)) | ||
| .frame(maxWidth: .infinity) | ||
| .minimumScaleFactor(0.9) | ||
| .padding(.all, 8) | ||
| } | ||
| .frame(width: 200, height: 25) | ||
| .buttonStyle(BitcoinFilled(tintColor: viewModel.buttonColor, isCapsule: true)) | ||
| .disabled(!isFirstTime && viewModel.seedPhrase.isEmpty) | ||
| .padding(.all, 25) | ||
| .buttonStyle( | ||
| BitcoinFilled( | ||
| tintColor: .accent, | ||
| isCapsule: true | ||
| ) | ||
| ) |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add loading state to wallet creation button.
Consider adding a loading state to provide feedback during wallet creation process.
+@State private var isCreatingWallet = false
+
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}Committable suggestion was skipped due to low confidence.
There was a problem hiding this comment.
Added to Todo list
There was a problem hiding this comment.
@danielnordh, understood. Would you like me to open a new GitHub issue to track this enhancement?
|
Thanks for the side-by-side screenshots! ColorColor change looks good, but there are some additional considerations I'm thinking about it:
Overall I'm good with the proposed color change though for now, but do think it should be made across the entire app for cohesion. Casinghttps://developer.apple.com/design/human-interface-guidelines/writing https://developer.apple.com/design/human-interface-guidelines/buttons I’m definitely not against apps that use Sentence case (one of my favorite bitcoin apps uses it), and don’t think Apple even thinks one is always better than the other, but it does seem like the strongest case for which would be the standard for an iOS wallet would be Title (per combination of HIG+Wallet)? UIDoes not work well on non-DynamicType or with Dynamic Type (even though I'm not as explicit about that here (yet) as I am in BDKSwiftExampleWallet), here are screenshots of proposed changes: 
TextI'm good with changing "create wallet" from "start node", good change! OtherWould encourage continuing discussion on each of these as separate Issues/PR's because this PR discussion might get too large and span too many different topics (and possibly opening up Issues before PR's for these items) Would love your help on some existing ui changes like #133 or large feature experimentation/implemenation like #132 I appreciate the experimentation on the |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
31-43: LGTM! Consider enhancing accessibility.The styling follows iOS design guidelines. Consider adding accessibility identifiers for UI testing.
Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) .foregroundColor(.accent) .frame(width: 150, height: 150, alignment: .center) .padding(40) + .accessibilityIdentifier("onboarding-logo")
Line range hint
49-89: Remove commented code.Remove the commented picker implementation to maintain clean production code. If needed, this code can be retrieved from version control history.
- // Default picker style - /* - HStack { - Text("Network") - Spacer() - Picker( - "Network", - selection: $viewModel.selectedNetwork - ) { - Text("Signet").tag(Network.signet) - Text("Testnet").tag(Network.testnet) - } - .pickerStyle(.automatic) - .tint(.accent) - .accessibilityLabel("Select bitcoin network") - } - [... rest of commented code ...] - */
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
LDKNodeMonday/View/Home/OnboardingView.swift(3 hunks)
🔇 Additional comments (4)
LDKNodeMonday/View/Home/OnboardingView.swift (4)
91-127: LGTM! Form-based picker implementation.
The new implementation using Form and NavigationLink provides a more native iOS experience and better accessibility.
132-139:
Enhance security and user experience of seed phrase input.
The TextField implementation should include security-focused modifiers.
TextField(
isFirstTime
? "24 word seed phrase (optional)" : "24 word seed phrase (required)",
text: $viewModel.seedPhrase
)
.textFieldStyle(.roundedBorder)
.submitLabel(.done)
+.keyboardType(.asciiCapable)
+.textContentType(.none)
+.autocorrectionDisabled(true)
+.autocapitalization(.none)
.padding(.horizontal, 50)152-161:
Add loading state to wallet creation button.
The button should provide feedback during wallet creation process.
+@State private var isCreatingWallet = false
+
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}164-164: Verify accessibility requirements for text size limitations.
The view limits dynamic type size to .accessibility1. Verify if this limitation aligns with your app's accessibility requirements and if users requiring larger text sizes are adequately supported.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (3)
LDKNodeMonday/View/Home/OnboardingView.swift (3)
28-40: LGTM! Consider adding accessibility label for the logo image.The layout and styling changes look good. The centered logo with accent color and properly weighted text create a clean hierarchy.
Add an accessibility label to the logo image:
Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) .foregroundColor(.accent) .frame(width: 150, height: 150, alignment: .center) .padding(40) + .accessibilityLabel("Monday Wallet Logo")
Line range hint
47-86: Remove commented code.The old picker implementation is commented out and should be removed to maintain code cleanliness.
- // Default picker style - /* - HStack { - Text("Network") - Spacer() - Picker( - "Network", - selection: $viewModel.selectedNetwork - ) { - Text("Signet").tag(Network.signet) - Text("Testnet").tag(Network.testnet) - } - .pickerStyle(.automatic) - .tint(.accent) - .accessibilityLabel("Select bitcoin network") - } - HStack { - Text("Server") - Spacer() - Picker( - "Esplora server", - selection: $viewModel.selectedURL - ) { - ForEach(viewModel.availableURLs, id: \.self) { url in - Text( - url.replacingOccurrences( - of: "https://", - with: "" - ).replacingOccurrences( - of: "http://", - with: "" - ) - ) - .tag(url) - } - } - .pickerStyle(.automatic) - .tint(.accent) - .accessibilityLabel("Select esplora server") - } - */
165-171: Enhance error alert messaging.The error alert could provide more specific guidance to users.
Alert( - title: Text(viewModel.onboardingViewError?.title ?? "Unknown"), - message: Text(viewModel.onboardingViewError?.detail ?? ""), + title: Text(viewModel.onboardingViewError?.title ?? "Error"), + message: Text(viewModel.onboardingViewError?.detail ?? "An unexpected error occurred. Please try again."), dismissButton: .default(Text("OK")) { viewModel.onboardingViewError = nil } )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🔇 Additional comments (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
129-136: Enhance security and user experience of seed phrase input.
The TextField needs additional security and usability configurations.
TextField(
isFirstTime
? "24 word seed phrase (optional)" : "24 word seed phrase (required)",
text: $viewModel.seedPhrase
)
.textFieldStyle(.roundedBorder)
.submitLabel(.done)
+.keyboardType(.asciiCapable)
+.textContentType(.none)
+.autocorrectionDisabled(true)
+.autocapitalization(.none)
.padding(.horizontal, 50)149-158: Add loading state to wallet creation button.
The button should provide feedback during wallet creation.
+@State private var isCreatingWallet = false
+
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Outside diff range and nitpick comments (7)
LDKNodeMonday/Info.plist (1)
Camera permission is required for QR code scanning functionality
The codebase actively uses QR code scanning in multiple features:
- Peer connection via QR code scanning in
PeerView.swift- Payment address scanning in
AddressView.swiftandAmountView.swift- Channel creation via QR code in
ChannelAddView.swiftAll these features depend on camera access, which requires the
NSCameraUsageDescriptionpermission key. TheUISupportsDocumentBrowserremoval appears safe as there's no active document browser functionality in the codebase.🔗 Analysis chain
Line range hint
4-9: Verify the impact of removed permissionsThe removal of
NSCameraUsageDescriptionandUISupportsDocumentBrowserkeys might affect features like QR code scanning and wallet import/export functionality.Let's verify if these features are still needed:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check for QR code scanning or camera usage in the codebase echo "Checking for QR code and camera usage..." rg -i "qr|camera|scan|uiimagepickercontroller" # Check for document-related functionality echo "Checking for document handling..." rg -i "documentbrowser|documentpicker|UIDocumentPickerViewController" # Check for wallet import/export functionality echo "Checking for wallet import/export..." rg -i "import.*wallet|export.*wallet|backup.*wallet"Length of output: 12664
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift (3)
Line range hint
89-91: Security: Handle mnemonic generation and storage securely.The mnemonic generation and storage is a critical security operation. Consider:
- Using secure key derivation
- Implementing proper encryption at rest
- Adding memory protection
Would you like me to provide a detailed implementation guide for secure mnemonic handling?
Line range hint
94-95: Critical: Handle node initialization errors properly.The node initialization uses force unwrapping (
try!) which could crash the app if the builder fails. This is particularly risky as it's the final step of initialization.- let ldkNode = try! nodeBuilder.build() // Handle error instead of "!" - self.ldkNode = ldkNode + do { + self.ldkNode = try nodeBuilder.build() + } catch { + logger.error("Failed to initialize Lightning node: \(error)") + throw NodeInitializationError.builderFailed(error) + }
Line range hint
1-300: Consider implementing proper logging throughout the service.The service handles critical operations but lacks comprehensive logging. Consider adding structured logging for:
- Node state changes
- Payment operations
- Channel operations
- Error conditions
Would you like me to provide a logging implementation guide?
LDKNodeMonday/View/Home/ImportWalletView.swift (3)
19-19: Remove unusedseedPhrasestate variableThe
seedPhrasestate variable declared here is unused, as theTextFieldbinds directly toviewModel.seedPhrase. Remove the unused variable to clean up the code.Apply this diff to remove the unused variable:
-@State private var seedPhrase = ""
29-29: Use.isEmptyto check if array is emptyInstead of comparing the array to an empty array, use the
.isEmptyproperty for clarity and efficiency.Apply this diff:
-if viewModel.seedPhraseArray == [] { +if viewModel.seedPhraseArray.isEmpty {
66-66: Simplify the button's disabled conditionSimplify the condition by directly using the
.isEmptyproperty for better readability.Apply this diff:
-.disabled(viewModel.seedPhraseArray == [] ? true : false) +.disabled(viewModel.seedPhraseArray.isEmpty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (9)
LDKNodeMonday.xcodeproj/project.pbxproj(12 hunks)LDKNodeMonday/Extensions/ChannelDetails+Extensions.swift(1 hunks)LDKNodeMonday/Info.plist(1 hunks)LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift(1 hunks)LDKNodeMonday/Utilities/Constants.swift(2 hunks)LDKNodeMonday/View Model/Home/OnboardingViewModel.swift(5 hunks)LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/NetworkSettingsView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- LDKNodeMonday.xcodeproj/project.pbxproj
🔇 Additional comments (7)
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift (1)
27-27: Verify the default Esplora server URL configuration.
The default Esplora server URL is being set to Mutiny's Signet server. While this works, it's important to ensure this aligns with the application's requirements and server reliability.
✅ Verification successful
Let me gather more context about the Esplora server configuration to ensure we have a complete picture.
Based on the comprehensive context gathered, I can now provide the final response:
The default Esplora server URL configuration is correctly implemented.
The Mutiny Signet server URL is appropriately used as a fallback and is part of a well-structured configuration system where:
- It's properly defined in Constants.Config.EsploraServerURLNetwork.Signet
- Users can select from multiple pre-configured servers during onboarding
- The URL is persistently stored and retrieved via KeyClient
- The configuration aligns with the application's network selection logic (defaulting to signet)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if the Esplora URL is referenced consistently across the codebase
rg -A 2 "mutiny.url"
# Check for any other Esplora URL configurations that might conflict
ast-grep --pattern 'EsploraServer.*url'
Length of output: 410
Script:
#!/bin/bash
# Check for all Esplora-related configurations
rg -i "esplora" -A 3
# Look for URL configurations in Constants
fd "Constants.swift" --exec cat {}
# Check for network-related configurations
rg "Network\(" -A 2
Length of output: 24876
LDKNodeMonday/Extensions/ChannelDetails+Extensions.swift (2)
Line range hint 56-64: Review the equality and hashing implementation.
The current implementation only considers channelId for equality and hashing. This might be insufficient as:
- Two channels could theoretically have the same ID but different counterparties
- Other fields might be relevant for identity (e.g.,
counterpartyNodeId,fundingTxo)
Let's verify if there are other usages of channel equality in the codebase:
Consider including additional fields in the equality and hashing implementation to ensure correct behavior when used in collections. For example:
extension ChannelDetails {
public static func == (lhs: ChannelDetails, rhs: ChannelDetails) -> Bool {
- return lhs.channelId == rhs.channelId
+ return lhs.channelId == rhs.channelId &&
+ lhs.counterpartyNodeId == rhs.counterpartyNodeId &&
+ lhs.fundingTxo == rhs.fundingTxo
}
public func hash(into hasher: inout Hasher) {
- hasher.combine(channelId)
+ hasher.combine(channelId)
+ hasher.combine(counterpartyNodeId)
+ hasher.combine(fundingTxo)
}
}✅ Verification successful
Based on the search results, I can see that ChannelDetails is primarily used in array contexts for listing channels (listChannels()) and storing them in view models, without any evidence of being used in Sets, Dictionaries, or equality comparisons. The implementation appears to be used only for conforming to standard Swift protocols, and the channelId is indeed a unique identifier for a channel in the Lightning Network protocol.
The current equality and hashing implementation is appropriate.
The implementation using only channelId is sufficient because:
- In the Lightning Network protocol, channel IDs are guaranteed to be unique
- The codebase only uses
ChannelDetailsin array contexts for display purposes - There's no evidence of
ChannelDetailsbeing used in Sets or Dictionaries where stricter equality would be needed - The implementation follows the principle of using the minimal unique identifier for equality
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for ChannelDetails comparisons or collections
rg "ChannelDetails.*=="
rg "Set<ChannelDetails>"
rg "Dictionary.*ChannelDetails"
Length of output: 86
Script:
#!/bin/bash
# Let's try a broader search to understand the usage of ChannelDetails
# 1. Find where ChannelDetails is used in collections or comparisons
rg -l "ChannelDetails" | xargs rg -l "Set|Dictionary|Map|\bequals\b|=="
# 2. Find the definition of ChannelDetails to understand its properties
ast-grep --pattern 'struct ChannelDetails {
$$$
}'
# 3. Look for any array or collection usage
rg "\\[ChannelDetails\\]"
Length of output: 1958
Script:
#!/bin/bash
# Let's check the actual usage context of ChannelDetails arrays
rg -A 5 -B 5 "\[ChannelDetails\]"
# Let's also check if there's any filtering or comparison of channels
rg -A 3 "channels.*filter|channels.*where|channels.*first"
# Find the struct definition in a different way
fd -e swift | xargs rg -l "struct ChannelDetails" | xargs cat
Length of output: 4077
Line range hint 56-64: Verify the necessity of this change in a UI-focused PR.
This change appears to be unrelated to the PR's stated objectives of "UI - onboarding styling and colors". Consider moving these changes to a separate PR focused on channel management functionality.
Let's check if this change is referenced in the UI changes:
LDKNodeMonday/View/Home/NetworkSettingsView.swift (1)
14-14:
Use @ObservedObject instead of @Bindable for view model
The @Bindable property wrapper is not a standard SwiftUI attribute and may cause issues. To observe changes in your view model, use @ObservedObject or @StateObject instead.
Apply this diff to correct the property wrapper:
-@Bindable var viewModel: OnboardingViewModel
+@ObservedObject var viewModel: OnboardingViewModelLikely invalid or redundant comment.
LDKNodeMonday/View/Home/ImportWalletView.swift (1)
33-38: Enhance security and user experience of seed phrase input
Consider adding appropriate keyboard and text input modifiers to the TextField for better security and user experience.
Apply this diff to improve the TextField:
TextField("24 word recovery phrase",
text: $viewModel.seedPhrase
)
.frame(width: 260, height: 40)
.tint(.accentColor)
+.keyboardType(.asciiCapable)
+.autocorrectionDisabled(true)
+.autocapitalization(.none)
.padding([.leading, .trailing], 20)
.submitLabel(.done)
.overlay(
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 2)
)LDKNodeMonday/View/Home/OnboardingView.swift (2)
66-68: Add loading state to the "Create wallet" button
Consider adding a loading state to provide feedback during the wallet creation process, enhancing user experience.
Apply this diff to implement the loading state:
+@State private var isCreatingWallet = false
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
+ isCreatingWallet = false // Consider resetting after completion or on success/failure
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}85-85: Avoid limiting Dynamic Type sizes to improve accessibility
Restricting the Dynamic Type size to .accessibility1 may hinder users who require larger text sizes. Consider supporting all Dynamic Type sizes and adjust your layout accordingly.
Apply this diff:
-}.dynamicTypeSize(...DynamicTypeSize.accessibility1) // Sets max dynamic size for all Text
+// Consider removing the limitation and testing with larger sizes
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
LDKNodeMonday/View/Home/OnboardingView.swift (3)
31-44: Enhance accessibility for network settings button.While the implementation follows iOS HIG, consider adding accessibility modifiers to improve VoiceOver support.
Button(action: { showingNetworkSettingsSheet.toggle() }, label: { HStack(spacing: 5) { Text(viewModel.selectedNetwork.description.capitalized) Image(systemName: "gearshape") } }) +.accessibilityLabel("Network Settings") +.accessibilityHint("Opens network configuration options") .sheet(isPresented: $showingNetworkSettingsSheet) { NetworkSettingsView(viewModel: viewModel) }
48-53: Consider responsive sizing for the logo.Using a fixed frame size might not scale well across different device sizes. Consider using relative sizing or GeometryReader.
Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) .foregroundColor(.accent) - .frame(width: 150, height: 150, alignment: .center) + .frame(maxWidth: min(UIScreen.main.bounds.width * 0.4, 150), + maxHeight: min(UIScreen.main.bounds.width * 0.4, 150), + alignment: .center) .padding(40)
88-95: Enhance error feedback with haptics.Add haptic feedback when showing errors to improve the user experience.
.alert(isPresented: $showingOnboardingViewErrorAlert) { + UINotificationFeedbackGenerator().notificationOccurred(.error) Alert( title: Text(viewModel.onboardingViewError?.title ?? "Unknown error"), message: Text(viewModel.onboardingViewError?.detail ?? "No details"), dismissButton: .default(Text("OK")) { viewModel.onboardingViewError = nil } ) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- LDKNodeMonday/View/Home/ImportWalletView.swift
🔇 Additional comments (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
16-16:
Switch from @State to @ObservedObject for view model.
Using @State for reference types like view models can lead to unexpected behavior as SwiftUI won't properly observe changes.
-@State var viewModel: OnboardingViewModel
+@ObservedObject var viewModel: OnboardingViewModel66-74: 🛠️ Refactor suggestion
Add loading state to wallet creation button.
Users need visual feedback during wallet creation to prevent multiple taps and improve UX.
+@State private var isCreatingWallet = false
+
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}
|
Should be good for review now. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
LDKNodeMonday/View/Home/OnboardingView.swift (1)
48-61: Consider improving layout responsiveness.While the styling looks good, consider these improvements for better accessibility and device compatibility:
- Replace fixed logo size with relative sizing using GeometryReader or flexible frame
- Allow description text to be more flexible for different screen sizes
Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) .foregroundColor(.accent) - .frame(width: 150, height: 150, alignment: .center) + .frame(maxWidth: 150, maxHeight: 150, alignment: .center) + .frame(minWidth: 100, minHeight: 100) .padding(40) Text("Monday Wallet") .font(.largeTitle .weight(.semibold)) Text("An example bitcoin wallet\npowered by LDK Node") .font(.body) .multilineTextAlignment(.center) - .fixedSize(horizontal: false, vertical: true) + .lineLimit(2)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (5)
LDKNodeMonday.xcodeproj/project.pbxproj(12 hunks)LDKNodeMonday/Info.plist(1 hunks)LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/NetworkSettingsView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- LDKNodeMonday/View/Home/NetworkSettingsView.swift
- LDKNodeMonday/View/Home/ImportWalletView.swift
- LDKNodeMonday/Info.plist
🧰 Additional context used
📓 Learnings (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:0-0
Timestamp: 2024-12-04T10:50:10.272Z
Learning: In the SwiftUI view `OnboardingView` in `LDKNodeMonday/View/Home/OnboardingView.swift`, limit the dynamic type size to `.accessibility2` to prevent breaking readability in buttons and other UI elements.
LDKNodeMonday.xcodeproj/project.pbxproj (1)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday.xcodeproj/project.pbxproj:180-180
Timestamp: 2024-12-05T17:54:34.328Z
Learning: Multiple LDKNode framework references in `LDKNodeMonday.xcodeproj/project.pbxproj` may be intentional when using custom forks or multiple versions of LDKNode, and should not be flagged as duplicates.
🔇 Additional comments (7)
LDKNodeMonday/View/Home/OnboardingView.swift (4)
15-19: LGTM: Property wrappers are correctly implemented.
The use of @State for the view model aligns with iOS 17's Observable pattern, and the sheet state variables follow SwiftUI best practices.
30-44: LGTM: Network settings UI follows iOS design guidelines.
The implementation demonstrates good practices:
- Clear visual hierarchy with HStack
- Semantic use of SF Symbols (gearshape)
- Proper text capitalization
- Standard sheet presentation pattern
87-97: LGTM: Dynamic type and alert implementation are well-configured.
- Dynamic type size limit to
.accessibility2is intentional to prevent breaking readability in buttons - Alert implementation follows SwiftUI best practices with proper error handling
68-85: 🛠️ Refactor suggestion
Add loading state to wallet creation button.
Consider adding a loading state to provide feedback during wallet creation process.
+@State private var isCreatingWallet = false
+
Button("Create wallet") {
+ isCreatingWallet = true
viewModel.saveSeed()
isFirstTime = false
}
.buttonStyle(
BitcoinFilled(
tintColor: .accent,
isCapsule: true
)
)
+.disabled(isCreatingWallet)
+.overlay {
+ if isCreatingWallet {
+ ProgressView()
+ .tint(.accent)
+ }
+}LDKNodeMonday.xcodeproj/project.pbxproj (3)
96-97: LGTM: New view files are properly integrated.
NetworkSettingsView.swift and ImportWalletView.swift are correctly added to the project structure and organized in the Home group.
Also applies to: 306-307
180-180: LGTM: Framework references are configured as intended.
Multiple LDKNode framework references are present, which may be intentional for managing custom forks or different versions.
907-914: Consider using a version range for LDKNode dependency.
While pinning to exact version 0.4.0 provides stability, it may cause you to miss important security updates. Consider using a version range that allows minor updates.
requirement = {
- kind = exactVersion;
- version = 0.4.0;
+ kind = upToNextMinor;
+ minimumVersion = "0.4.0";
};
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
LDKNodeMonday/Utilities/Constants.swift (2)
31-31: Consider documenting the use of HTTP for local developmentWhile using HTTP for localhost is common, it would be helpful to add a comment explaining why HTTPS isn't required in this case.
- static let local = EsploraServer(name: "Local", url: "http://127.0.0.1:3002") + // Using HTTP for local development environment + static let local = EsploraServer(name: "Local", url: "http://127.0.0.1:3002")
118-121: Consider enhancing the EsploraServer struct with better type safetyThe current implementation could benefit from using
URLtype instead ofStringfor the url property and adding validation.Here's a suggested improvement:
struct EsploraServer: Hashable { var name: String - var url: String + var url: URL + + init(name: String, url: String) throws { + guard let validURL = URL(string: url) else { + throw URLError(.badURL) + } + self.name = name + self.url = validURL + } }This change would:
- Ensure URL validity at initialization
- Provide better type safety with
URLtype- Make it clear when URL parsing fails
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (6)
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift(1 hunks)LDKNodeMonday/Utilities/Constants.swift(2 hunks)LDKNodeMonday/View Model/Home/OnboardingViewModel.swift(5 hunks)LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/NetworkSettingsView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift
- LDKNodeMonday/View/Home/NetworkSettingsView.swift
- LDKNodeMonday/View/Home/ImportWalletView.swift
🧰 Additional context used
📓 Learnings (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:0-0
Timestamp: 2024-12-04T10:50:10.272Z
Learning: In the SwiftUI view `OnboardingView` in `LDKNodeMonday/View/Home/OnboardingView.swift`, limit the dynamic type size to `.accessibility2` to prevent breaking readability in buttons and other UI elements.
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (1)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
🔇 Additional comments (6)
LDKNodeMonday/Utilities/Constants.swift (3)
17-24: LGTM! Well-structured Bitcoin mainnet server configurations.
The implementation uses secure HTTPS URLs and provides a clear organization of server information.
37-37: Use HTTPS instead of HTTP for network URLs
The URL for the BDK Signet API uses http, which is insecure. Consider using https to ensure secure communication.
45-48: Use HTTPS instead of HTTP for network URLs
The URL for the Blockstream Testnet API uses http, which is insecure. Update it to use https to ensure secure communication.
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (3)
26-27: Avoid force unwrapping to prevent potential crashes
The use of availableEsploraServers.first! force unwraps an optional, which can lead to a runtime crash if the array is empty. Consider safely unwrapping using if let or guard let.
89-91: Handle optionals safely when retrieving Esplora server
Force unwrapping availableEsploraServers.first(where: { $0.url == esploraURL })! can cause a crash if there's no matching server. Use safe unwrapping to handle cases where the server is not found.
93-93: Avoid force unwrapping to prevent potential crashes
Using availableEsploraServers.first! without checking if the array is empty can lead to a crash. Safely unwrap to handle empty arrays gracefully.
There was a problem hiding this comment.
This is looking good, some comments about unimportant things, some comments about nice things, some changes requested: comments for changes I’m requesting.
Some of the changes requested are not even that what you have is wrong and what I have is far superior, but might just be that it breaks convention with the current codebase, and I don’t want you having to change it in other unrelated places in the code base if we are changing the convention right now (would rather just do that in follow up PR’s to allow us to not expand the size of the changes in this PR so this PR can be merged sooner rather than later).
Co-authored-by: Matthew Ramsden <6657488+reez@users.noreply.github.com>
…tside classes, fix use in OnboardingViewModel
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (3)
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (3)
Line range hint
38-53: Consider adding URL validationWhile the EsploraServer management is well-structured, consider adding URL validation before saving to ensure the URL is well-formed and accessible.
var selectedEsploraServer: EsploraServer = EsploraServer.mutiny_signet { didSet { do { + guard URL(string: selectedEsploraServer.url) != nil else { + throw MondayError( + title: "Invalid URL", + detail: "The selected Esplora server URL is invalid" + ) + } try KeyClient.live.saveEsploraURL(selectedEsploraServer.url)
106-109: Consider encapsulating UserDefaults accessDirect UserDefaults manipulation could be moved to a dedicated configuration service for better encapsulation and maintainability.
+ private let defaults: UserDefaults + + init(defaults: UserDefaults = .standard) { + self.defaults = defaults + } + + private func setOnboardingComplete() { + defaults.set(false, forKey: "isOnboarding") + } func saveSeed() { do { let backupInfo = BackupInfo(mnemonic: seedPhrase) try KeyClient.live.saveBackupInfo(backupInfo) try KeyClient.live.saveNetwork(selectedNetwork.description) try KeyClient.live.saveEsploraURL(selectedEsploraServer.url) LightningNodeService.shared = LightningNodeService() DispatchQueue.main.async { - UserDefaults.standard.set(false, forKey: "isOnboarding") + setOnboardingComplete() }
13-13: Consider centralizing color managementSince this PR focuses on UI styling and colors, consider moving color management to a dedicated theme service that can handle both network colors and general UI colors consistently across the app.
This would:
- Improve maintainability of color schemes
- Make it easier to implement future theme changes
- Ensure consistency across the app
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
LDKNodeMonday/Utilities/Constants.swift(2 hunks)LDKNodeMonday/View Model/Home/OnboardingViewModel.swift(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- LDKNodeMonday/Utilities/Constants.swift
🧰 Additional context used
📓 Learnings (1)
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (1)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
🔇 Additional comments (2)
LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (2)
11-20: LGTM: Appropriate use of @observable macro
The transition from ObservableObject to @observable aligns with modern iOS 17 patterns and simplifies state management. The property observers are well-structured.
85-89: LGTM: Safe initialization of EsploraServer
The implementation properly handles potential nil values and follows best practices for optional handling.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (4)
LDKNodeMonday/View/Home/OnboardingView.swift (4)
29-47: Add accessibility label to network settings buttonWhile the network settings UI is well-structured, consider enhancing accessibility by adding an accessibility label that clearly describes the button's purpose.
Button( action: { showingNetworkSettingsSheet.toggle() }, label: { HStack(spacing: 5) { Text(viewModel.selectedNetwork.description.capitalized) Image(systemName: "gearshape") } } ) +.accessibilityLabel("Network settings: \(viewModel.selectedNetwork.description)")
52-57: Consider color scheme adaptation for logoThe logo currently uses
.accentcolor. Consider adapting the color based on the color scheme to ensure optimal visibility in both light and dark modes.Image(systemName: "bolt.horizontal.fill") .resizable() .aspectRatio(contentMode: .fit) - .foregroundColor(.accent) + .foregroundColor(Color.accent.opacity(colorScheme == .dark ? 0.9 : 1.0))
70-79: Add haptic feedback for wallet creationConsider adding haptic feedback to provide tactile confirmation when creating a wallet.
Button("Create wallet") { + let impactMed = UIImpactFeedbackGenerator(style: .medium) + impactMed.impactOccurred() viewModel.saveSeed() isOnboarding = false }
93-99: Enhance alert accessibilityConsider adding more descriptive accessibility labels to the alert to improve the experience for VoiceOver users.
Alert( title: Text(viewModel.onboardingViewError?.title ?? "Unknown error"), message: Text(viewModel.onboardingViewError?.detail ?? "No details"), dismissButton: .default(Text("OK")) { viewModel.onboardingViewError = nil } ) +.accessibilityLabel("\(viewModel.onboardingViewError?.title ?? "Error")") +.accessibilityHint("\(viewModel.onboardingViewError?.detail ?? "")")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift(1 hunks)LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/NetworkSettingsView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift
- LDKNodeMonday/View/Home/NetworkSettingsView.swift
- LDKNodeMonday/View/Home/ImportWalletView.swift
🧰 Additional context used
📓 Learnings (1)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:0-0
Timestamp: 2024-12-04T10:50:10.272Z
Learning: In the SwiftUI view `OnboardingView` in `LDKNodeMonday/View/Home/OnboardingView.swift`, limit the dynamic type size to `.accessibility2` to prevent breaking readability in buttons and other UI elements.
🔇 Additional comments (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
15-18: LGTM: State management follows iOS 17 best practices
The use of @State for the view model aligns with iOS 17's Observable pattern, and the sheet state management follows SwiftUI best practices.
93-100: Alert may not be displayed when an error occurs
The alert tied to showingOnboardingViewErrorAlert may not appear because showingOnboardingViewErrorAlert is never set to true when viewModel.onboardingViewError is updated.
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (1)
LDKNodeMonday/View/Home/OnboardingView.swift (1)
15-15: Use@Stateinstead of@ObservedObjectforviewModelIn iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use
@Statefor view models instead of@ObservedObject. This ensures proper state management and view updates.As per your previous learnings:
In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use
@Statefor view models instead of@ObservedObject.Consider updating the property wrapper:
- @ObservedObject var viewModel: OnboardingViewModel + @State var viewModel: OnboardingViewModel
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (8)
LDKNodeMonday.xcodeproj/project.pbxproj(12 hunks)LDKNodeMonday.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved(1 hunks)LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift(1 hunks)LDKNodeMonday/Utilities/Constants.swift(2 hunks)LDKNodeMonday/View Model/Home/OnboardingViewModel.swift(5 hunks)LDKNodeMonday/View/Home/ImportWalletView.swift(1 hunks)LDKNodeMonday/View/Home/NetworkSettingsView.swift(1 hunks)LDKNodeMonday/View/Home/OnboardingView.swift(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- LDKNodeMonday.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
🚧 Files skipped from review as they are similar to previous changes (3)
- LDKNodeMonday/View/Home/NetworkSettingsView.swift
- LDKNodeMonday/Service/Lightning Service/LightningNodeService.swift
- LDKNodeMonday/View/Home/ImportWalletView.swift
🧰 Additional context used
📓 Learnings (2)
LDKNodeMonday/View/Home/OnboardingView.swift (2)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:15-15
Timestamp: 2024-12-04T10:54:52.311Z
Learning: In iOS 17, when using the new Observable pattern in SwiftUI, it's appropriate to use `@State` for view models instead of `@ObservedObject`.
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday/View/Home/OnboardingView.swift:0-0
Timestamp: 2024-12-04T10:50:10.272Z
Learning: In the SwiftUI view `OnboardingView` in `LDKNodeMonday/View/Home/OnboardingView.swift`, limit the dynamic type size to `.accessibility2` to prevent breaking readability in buttons and other UI elements.
LDKNodeMonday.xcodeproj/project.pbxproj (1)
Learnt from: danielnordh
PR: reez/Monday#131
File: LDKNodeMonday.xcodeproj/project.pbxproj:180-180
Timestamp: 2024-12-05T17:54:34.328Z
Learning: Multiple LDKNode framework references in `LDKNodeMonday.xcodeproj/project.pbxproj` may be intentional when using custom forks or multiple versions of LDKNode, and should not be flagged as duplicates.
🔇 Additional comments (5)
LDKNodeMonday.xcodeproj/project.pbxproj (1)
910-917: 🛠️ Refactor suggestion
Consider using a version range for LDKNode dependency
While pinning to exact version 0.4.0 provides stability, it may cause you to miss important security updates. Consider using a version range that allows minor updates.
Update the package requirement to allow minor version updates:
requirement = {
- kind = exactVersion;
- version = 0.4.0;
+ kind = upToNextMinor;
+ minimumVersion = "0.4.0";
};LDKNodeMonday/View Model/Home/OnboardingViewModel.swift (1)
26-28:
Handle absence of available Esplora servers appropriately
Currently, if availableEsploraServers is empty, selectedEsploraServer is set to an EsploraServer with empty name and url, which could lead to unexpected behavior elsewhere in the application. It's better to handle this case explicitly, perhaps by notifying the user or providing a valid default server.
Consider modifying the code as follows:
- self.selectedEsploraServer =
- availableEsploraServers.first ?? EsploraServer(name: "", url: "")
+ if let firstServer = availableEsploraServers.first {
+ self.selectedEsploraServer = firstServer
+ } else {
+ // Handle the case when no servers are available
+ self.onboardingViewError = .init(
+ title: "No Esplora Servers Available",
+ detail: "Please check your network settings."
+ )
+ }Likely invalid or redundant comment.
LDKNodeMonday/Utilities/Constants.swift (2)
109-109: Use HTTPS instead of HTTP for network URLs
The URL for the BDK Signet API uses http, which is insecure. Consider updating it to use https to ensure secure communication.
Apply this diff to update the URL:
- static let bdk_signet = EsploraServer(name: "BDK", url: "http://signet.bitcoindevkit.net")
+ static let bdk_signet = EsploraServer(name: "BDK", url: "https://signet.bitcoindevkit.net")115-115: Use HTTPS instead of HTTP for network URLs
The URL for the Blockstream Testnet API uses http, which is insecure. Update it to use https to ensure secure communication.
Apply this diff to update the URL:
- url: "http://blockstream.info/testnet/api"
+ url: "https://blockstream.info/testnet/api"LDKNodeMonday/View/Home/OnboardingView.swift (1)
90-91: Reconsider dynamic type size limitation for better accessibility
Limiting the dynamic type size to .accessibility2 might prevent users who require larger text sizes from comfortably using the app. Consider adjusting the layout to support larger dynamic type sizes instead of capping it.
|
Thanks for the review, good points.
|
|
Yes this looks good! only thing left for approval is the merge conflict, once that is resolved I will approve and merge- |
Description
This PR makes changes to the onboarding screen styling and colors.
Before / After light mode / After dark mode
Changelog notice
Checklists
All Submissions:
.swift-formatfileSummary by CodeRabbit
Release Notes
New Features
Bug Fixes
ldk-nodepackage and streamlined package management.Chores