-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain function names are wrong in their error messages #305
Comments
Thank you. Yes ... I imagine that is a not so uncommon bug in our current codebase. Currently, the design is such, as we don't want functions to hold another value (it's name) at runtime in hope to be as lightweight as possible (because everything is function in Rye, also all that are usually language specific constructs (if/for/fn/..). We will start profiling current implementation at some point and if it shows that this is not needed it will be changed to form that will be easier to be consistent. Or we would make a tool that checks this. We will see ... for now, there is only a manual method so PR with these fixes is more than welcome! |
I'll create a PR.
I found the instructions in the README |
Some functions are named incorrectly in their own error messages. Examples: - split\every appears as "split-every" in its own error messages - most of the cases I found have this form: backslash appears as hyphen - to-eyr and eyr\full both appear as "eyr" - this appears to be a copy/paste issue; there are some other occurrences - near-zero appears as "is-zero" - perhaps an artifact of a renaming - this function's descriptive string was also wrong
Address #305: function names in error messages
Testing script will get improved. Currently you can run it with:
|
Some function names of the form
foo\bar
appear asfoo-bar
in their own error messages.For example:
Note that the function is called "split-every" in the error message instead of "split\every". There are some other such cases in
evaldo/builtins.go
.I have a fix for at least some of these in my fork and am happy to create a pull request. This issue is, in part, to satisfy the request in CONTRIBUTIONS.md to create an issue before the PR.
Q: how do I run all the tests to make sure I haven't broken anything?
The text was updated successfully, but these errors were encountered: