[Adding math functions] Support Erf, Erfc, Erfcinv and Erfinv math functions #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikmota
changed the title
pratikmota
changed the title
pratikmota
changed the title
|
Nice, thank you Pratik. I'll look at the inf and NaN ... thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Testing:
Test in Rye:
Testcases check:
Doubts:
Do we need to add restriction for +Inf, -Inf and NaN values in our custom functions? In Rye command line it is giving proper value so i have removed it. but in Testcases it is giving me like below. Is it the correct thing?
But our test cases is not failed (FAILED: 0). It Passed if i compare with "NaN".