Unlimited words and Windows support #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the master version of github.com/pkg/term. The repo seems to be stale anyways (no commits for 3 years), so there's no point in waiting for a new release.
refaktor
approved these changes
Jun 13, 2024
|
I forgot to run go fmt, everything should pass now |
|
I got some golangci errors. If you can please run // Edit: Aha, saw now ... I will try again ... |
stefanb
added a commit
to stefanb/rye
that referenced
this pull request
Jul 23, 2024
Windows support was added by @xypwn in * refaktor#239 and then broken in * refaktor#262 ...which should be fixed in: https://github.com/refaktor/rye/blob/bd61e7f2d951f953a42c4d566e3969d88ffa218b/util/getcolumns_native.go#L18-L20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.