Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipes-functions] Adding exit-status, concat, args and close functions #351

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

pratikmota
Copy link
Contributor

@pratikmota pratikmota commented Sep 28, 2024

Changes:

  1. Adding new 4 functions
  2. exit-status, concat, args and close function

Testing:
image

  • when close is successful it will return nil so nothing is display in error
  • args i tried to check, I am bit confuse how to test it. As it will be used to take command line argument of main func.
  • For concat i created local a.txt and b.txt for testing.

@pratikmota pratikmota marked this pull request as ready for review September 28, 2024 11:01
Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratikmota U, great ... and thanks for exposing the doubts, questions.

In rye so far nothing should return nil ... if all is ok, it would make sense that it returns 0, if not a failure.

You can probably write a script and call it with additional args bin/rye script.rye to test the args function.

Good about concat. I haven't documented this yet, but instead of doing do\par pipes { } you can just call cc pipes (like cd - change directory) and then all code is in pipes context.

@refaktor refaktor merged commit 31d0320 into refaktor:main Sep 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants