acl & success_action_status options + PR18 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1)add acl option to initialise method and use in available calls defaults to ‘public-read’ so backwards compatible, but enables people to make private as desired. 2) also included deprecation fix from PR refile#18 3) added success_action_status: 201 to presign method to fix firefox xml parse error: XML Parsing Error: no element found Location: moz-nullprincipal:{28d28eb9-bcef-f842-8355-54e833de9cd1} Line Number 1, Column 1:
|
I want this feature 👍 |
|
@jnicklas can we have a new release with this feature? |
|
I need this feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaults to ‘public-read’ so backwards compatible, but enables people
to make private as desired.
success_action_status: 201to presign method to fix firefoxxml parse error:
XML Parsing Error: no element found Location: moz-nullprincipal:{28d28eb9-bcef-f842-8355-54e833de9cd1} Line Number 1, Column 1: