Add isNewDiscussion and add it to hasRichTextEditor

[kang8]

The new discussion page will exist in the repo and org, e.g.:

• https://github.com/withastro/roadmap/discussions/new?category=proposal
• https://github.com/orgs/community/discussions/new?category=pull-requests

And must excluded new discussion choose page, e.g.:

• https://github.com/orgs/reading-together/discussions/new/choose

Solved: #175

[fregante]

Thank you! 💚

[fregante]

Actually this is not right. The “new discussion” page is not a “discussion”, there’s no discussion there.

#175 mentions hasRichTextEditor. I think this should be moved to isNewDiscussion and then isNewDiscussion should be added to hasRichTextEditor

[fregante]

Why? If you remove the category, it's redirected to https://github.com/withastro/roadmap/discussions/new/choose

Also sindresorhus/meta#7. I'm not sure why this lint rule isn't complaining https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-null.md

Suggested change

&& new URLSearchParams(url.search).get('category') !== null;

[kang8]

If you remove the category, it's redirected to withastro/roadmap/discussions/new/choose

Yes, But is withastro/roadmap/discussions/new/choose a new discussions? Because I'm referring to isNewIssue(), which does not match issue/new/choose, see Test CI for more details.

Also sindresorhus/meta#7. I'm not sure why this lint rule isn't complaining sindresorhus/eslint-plugin-unicorn@main/docs/rules/no-null.md

The no-null has an option: checkStrictEquality, which is set to false by default. It must be manually enabled:

  	"xo": {
		"overrides": [
			"rules": {
			...
+			"unicorn/no-null" : ["error", { "checkStrictEquality": false }],
			}
		]
	}

[fregante]

is withastro/roadmap/discussions/new/choose a new discussions

It's not and it's not matched by getRepo(url)?.path === 'discussions/new' || getOrg(url)?.path === 'discussions/new' already. Redirects are not taken into considerations because github-url-detection is meant to be used on real/final URLs.

[kang8]

👍🏽 I have already removed the category check.

[fregante]

Thank you!