-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unpublished Safari build #3677
Conversation
You need to gitignore:
|
How to test
Questions
ReviewAll the new files are autogenerated. Suggestions welcome, even if it's just to rename files. NextI think this PR won't need substantial work, but the next steps in new PRs will be:
|
Regarding point 4: I think there's no way around it. Enterprise support in Safari requires some changes:
|
You already use the nolookbehind variants, so that's fixed 👍 Another patch I have for Safari is the following CSS: .rgh-parse-backticks {
display: inline-block;
} This fixes line-wrapping of code blocks in issues list. |
Thanks for making me notice that. It looks like a Safari bug. <span className="sr-only">`</span>
<code className="rgh-parse-backticks">{text.trim()}</code>
<span className="sr-only">`</span> |
The build was broken but the error was silenced due to https://github.com/webpack/webpack/issues/11789
Related to #14
This PR
currently doesn't include any custom code,it'sjustthe direct result of:Next:
Find solution the lack of negative lookbehinds support 🤦♂️
I saw that @lautis’ wrapper forces compatible versions of those modules for Safari:
lautis/refined-github-safari@8eebe28#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L10
We can just undo Update dependencies; make Firefox 78 the minimum version #3316
Cleanup options CSS
Fix options’s filter and fit-textarea
Find out why
permission
hosts aren't automatically allowed