-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT]ListButton
from @refinedev/mui
doesn't implement the meta
query properly
#6528
Comments
The issue arises because the listUrl function in the useNavigation hook isn't properly handling query parameters from the meta object when generating URLs. This impacts both legacy and modern router implementations.
The key change will involve updating the composeRoute call: The updated code ensures existing parameters are preserved, new filters are added seamlessly, and the URL structure stays consistent. I'll be submitting a PR with these changes . Would you like me to proceed with the implementation? |
That sounds good to me, the maintainers will point out anything that may be amiss if any. I also suggest you check the other useNavigationButton uses incase they have a similar issue. |
@arndom thank you for reporting! We can treat this one as a feature request. @OmkarBansod02 Thank you for your interest, while your guess on Instead of working on Changing the lines here refine/packages/core/src/hooks/navigation/index.ts Lines 295 to 298 in 454515f
return go({
to: composeRoute(listActionRoute, resourceItem?.meta, parsed, meta),
type: "path",
+ query: meta.query,
}) as string; query will be handled by the |
ListButton
from @refinedev/mui
doesn't implement the meta
query properlyListButton
from @refinedev/mui
doesn't implement the meta
query properly
Describe the bug
/contacts
useNavigationButton
from@refinedev/core
is handling the meta proplistUrl
inside the definition ofuseNavigation
, though I'm unsure since I haven't indepthly gone through the source.Steps To Reproduce
Expected behavior
Packages
Additional Context
No response
The text was updated successfully, but these errors were encountered: