Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Mantine): support mantine 7 #6345

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

alodela
Copy link

@alodela alodela commented Sep 17, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Support for Mantine 5

What is the new behaviour?

Continuing the work done in #5340 to support Mantine 7

Notes for reviewers

Notable problems:
Mantine 7 uses CSS modules for styling, and @refinedev/mantine uses tsup to build, which doesn't support css modules
egoist/tsup#536

Any input or feedback welcome

Mantine migration guides:
https://v6.mantine.dev/changelog/6-0-0/
https://mantine.dev/guides/6x-to-7x/

closes #5178

glebtv and others added 30 commits February 21, 2024 14:53
Co-authored-by: Alican Erdurmaz <alicanerdurmaz@gmail.com>
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: ba364b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@refinedev/inferencer Major
@refinedev/live-previews Minor
@refinedev/mantine Major
@refinedev/ui-tests Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alodela alodela marked this pull request as ready for review September 17, 2024 23:38
@alodela alodela requested a review from a team as a code owner September 17, 2024 23:38
@aliemir
Copy link
Member

aliemir commented Sep 18, 2024

Hey @alodela, thank you for your effort, great job! (Also thanks to @glebtv). 🚀 🚀 About the change from emotion to CSS Modules, I'm not sure if this requires a big change for @refinedev/mantine. For our custom components, we can use styles prop and combine it with css variables I guess, won't that work properly?

I'll try to review all files as soon as possible. Of course there can be changes in the overall styling and we won't have issues with them. I'll mainly check for components to make sure we're not missing any features we're trying to keep all UI packages aligned with. 🙏

@alodela
Copy link
Author

alodela commented Sep 20, 2024

Hi @aliemir, I kept the note about the Mantine CSS module from the previous PR, just in case. So far, I haven't seen any issues. The Mantine CSS modules can be included in the Refine app, and as you said, use the styles prop for custom components included in the package.

I fixed the issues in the examples, and hopefully, everything will pass the checks next time. I'll be keeping an eye on the PR for any comments. Thanks.

@hanza93
Copy link

hanza93 commented Oct 6, 2024

this is great, how can we starting building with this branch @alodela 🙏

@BatuhanW BatuhanW changed the base branch from master to releases/october October 7, 2024 12:24
@alodela
Copy link
Author

alodela commented Oct 8, 2024

this is great, how can we starting building with this branch @alodela 🙏

@hanza93 you can install @refinedev/mantine from my forked repository. Also, make sure to use the latest versions of the rest of the @refinedev/* packages. Here's what I'm doing to build from my branch:

"@refinedev/mantine": "github:alodela/refine#path:packages/mantine&mantine7.v4",

Just consider this PR is still under review and might change.

@aliemir aliemir deleted the branch refinedev:master October 14, 2024 12:54
@aliemir aliemir closed this Oct 14, 2024
@aliemir aliemir reopened this Oct 14, 2024
@aliemir aliemir changed the base branch from releases/october to master October 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Mantine v7 support?
5 participants